Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312129 - app-text/xmldiff: Verify and potentially improve Python-related code
Summary: app-text/xmldiff: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-30 16:55 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-01-08 18:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xmldiff-0.6.9.ebuild.patch (xmldiff-0.6.9.ebuild.patch,791 bytes, patch)
2010-05-01 00:39 UTC, David Abbott (RETIRED)
Details | Diff
xmldiff-0.6.9.ebuild.patch (xmldiff-0.6.9.ebuild.patch,720 bytes, patch)
2010-05-01 22:38 UTC, David Abbott (RETIRED)
Details | Diff
xmldiff-0.6.9-r1.ebuild (xmldiff-0.6.9-r1.ebuild,3.05 KB, text/plain)
2010-05-02 00:54 UTC, David Abbott (RETIRED)
Details
xmldiff-0.6.9-r1.ebuild (xmldiff-0.6.9-r1.ebuild,3.03 KB, text/plain)
2010-05-02 01:17 UTC, David Abbott (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-30 16:55:47 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 David Abbott (RETIRED) gentoo-dev 2010-05-01 00:39:21 UTC
Created attachment 229871 [details, diff]
xmldiff-0.6.9.ebuild.patch

Only works with Python 2

python3.1 setup.py build 
  File "setup.py", line 121
    except OSError, ex:
                  ^
SyntaxError: invalid syntax
 * ERROR: app-text/xmldiff-0.6.9-r1 failed:
 *   Building failed

patched ebuild works when Python 3 is set to active version.
arfrever is that the correct way?
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-01 11:46:00 UTC
RESTRICT_PYTHON_ABIS is for packages supporting installation for multiple Python ABIS.
python_set_active_version() is for packages not supporting installation for multiple Python ABIs.
distutils.eclass inherits python.eclass, so don't inherit python.eclass.
Comment 3 David Abbott (RETIRED) gentoo-dev 2010-05-01 22:38:14 UTC
Created attachment 229943 [details, diff]
xmldiff-0.6.9.ebuild.patch

Ok I think that is it.
Comment 4 David Abbott (RETIRED) gentoo-dev 2010-05-02 00:54:19 UTC
Created attachment 229963 [details]
xmldiff-0.6.9-r1.ebuild
Comment 5 David Abbott (RETIRED) gentoo-dev 2010-05-02 01:17:34 UTC
Created attachment 229967 [details]
xmldiff-0.6.9-r1.ebuild

fixed src_prepare()
Comment 6 David Abbott (RETIRED) gentoo-dev 2010-05-02 23:34:24 UTC
(In reply to comment #2)
> RESTRICT_PYTHON_ABIS is for packages supporting installation for multiple
> Python ABIS.

In the docs;
Ebuilds not working with some versions of Python should set RESTRICT_PYTHON_ABIS
# Package not supporting Python 3.
RESTRICT_PYTHON_ABIS="3.*"

so does this need to be in every ebuild because that covers both explanations.

> python_set_active_version() is for packages not supporting installation for
> multiple Python ABIs.
> distutils.eclass inherits python.eclass, so don't inherit python.eclass.
> 

Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-03 16:51:04 UTC
SUPPORT_PYTHON_ABIS and RESTRICT_PYTHON_ABIS are for packages, which can be installed for e.g. both Python 2.6 and 2.7 simultaneously (not necessarily for Python 3.1).
Comment 8 Michael Weber (RETIRED) gentoo-dev 2011-01-03 02:10:32 UTC
Ok, taking over by solving bug 349499.

I'll use

PYTHON_DEPEND="*"
SUPPORT_PYTHON_ABIS="1"
RESTRICT_PYTHON_ABIS="3.*"
Comment 9 Michael Weber (RETIRED) gentoo-dev 2011-01-03 02:17:17 UTC
+*xmldiff-0.6.10 (03 Jan 2011)
+*xmldiff-0.6.9-r1 (03 Jan 2011)
+
+  03 Jan 2011; Michael Weber <xmw@gentoo.org> +xmldiff-0.6.9-r1.ebuild,
+  +xmldiff-0.6.10.ebuild, metadata.xml:
+  Taking maintainership, resolving python issues (thanks to David Abbott on bug
+  312129) and bumping to 0.6.10 (thanks to Stefan de Konink <stefan@konink.de>
+  on bug 349499).
+
Comment 10 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-01-03 15:00:58 UTC
You haven't committed these changes.
Comment 11 Michael Weber (RETIRED) gentoo-dev 2011-01-08 18:46:20 UTC
second attempt, sorry for the inconvenicence
Comment 12 Michael Weber (RETIRED) gentoo-dev 2011-01-08 18:46:57 UTC
second attempt, sorry for my failure