| Summary: | app-misc/lcd4linux: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | idella4, lcd |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
| Attachments: |
ebuild patch
ebuild patch the added lcd4linux-header.patch revised ebuild patch |
||
Created attachment 293469 [details, diff]
ebuild patch
This comes with an extra. The build produces a QA issue, clearly missing a header file, which is sys/stat.h. I called it ${PN}"-header.patch and is appended in the ebuild patch. Probably too old to bother sending upstream, but it works
(In reply to comment #1) Use PYTHON_DEPEND="python? 2" Delete 'python? ( dev-lang/python )' from DEPEND/RDEPEND. Don't add 'python? ( =dev-lang/python-2* )' to DEPEND/RDEPEND. python_set_active_version() should be called only with USE="python". Created attachment 293679 [details, diff]
ebuild patch
(In reply to comment #3) This patch doesn't apply cleanly. Created attachment 293801 [details, diff]
the added lcd4linux-header.patch
Created attachment 293805 [details, diff]
revised ebuild patch
remade it, first ofcourse add to files the previous lcd4linux-header.patch.
Double checked this patch and it takes.
+ 06 May 2012; Pacho Ramos <pacho@gentoo.org> + +files/lcd4linux-0.10.1_rc2-missing-header.patch, + lcd4linux-0.10.1_rc2-r2.ebuild: + Let it work with python3 as main interpreter and include missing header + (#311529 by Ian Delaney). + |
- If this package can be used as a library and installs Python modules (*.so or *.py) into directories specific to given versions of Python, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1]. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml