Summary: | dev-python/pysvn fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Python Gentoo Team <python> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ewoud+gentoo |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Build log
Corrected pysvn-1.7.1-skip_root_test.patch A patch to fix the root url problem |
Description
Diego Elio Pettenò (RETIRED)
2010-01-03 00:28:17 UTC
Created attachment 214971 [details]
Build log
Created attachment 217874 [details, diff]
Corrected pysvn-1.7.1-skip_root_test.patch
A corrected patch. The previous patch added nested if statements which seemed to break without a semicolon. I've also added then to the if statement.
Running the test both as normal user and as root now works as expected.
Still, I think a patch that skips a test isn't a really nice patch. The cause of the problem is that `whoami` is replaced by <username>. if you run the test, it attempts to create a SVN repo with testroot-06 as name. You can guess what's replaced and doesn't match the expected result...
I've filed http://pysvn.tigris.org/issues/show_bug.cgi?id=147 so hopefully it'll be fixed upstream instead. Copied from pysvn bugzilla: ------- Additional comments from barryscott@tigris.org Sun Jan 31 10:07:37 -0800 2010 ------- I have fixed this on trunk by changing svn_cmd.py to use root_URL not root<SP>URL. I have also updated the known good results to match. Fixed committed in r1291 and r1292 on trunk. ------- See http://pysvn.tigris.org/source/browse/pysvn?view=rev&revision=1291 and http://pysvn.tigris.org/source/browse/pysvn?view=rev&revision=1292. Created attachment 218046 [details, diff] A patch to fix the root url problem svn diff http://pysvn.tigris.org/svn/pysvn/trunk/pysvn/Extension/ -r 1290:1293 > files/pysvn-fix_root_url.patch Applies to 1.7.2, haven't tested 1.7.1. Note that in revision 1293 a minor correction was applied. It seems 1.7.4 has entered the tree which doesn't need this patch anymore, yet it's still applied. Removing the epatch line from src_prepare should close this bug. pysvn-1.7.1-skip_root_test.patch has been deleted. |