Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299422 - dev-python/pysvn fails tests
Summary: dev-python/pysvn fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-03 00:28 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-10-23 15:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (pysvn-1.7.1:20100102-191727.log,48.49 KB, text/plain)
2010-01-03 00:28 UTC, Diego Elio Pettenò (RETIRED)
Details
Corrected pysvn-1.7.1-skip_root_test.patch (pysvn-1.7.1-skip_root_test.patch,992 bytes, patch)
2010-01-29 20:12 UTC, Ewoud Kohl van Wijngaarden
Details | Diff
A patch to fix the root url problem (pysvn-fix_root_url.patch,15.55 KB, patch)
2010-02-01 02:19 UTC, Ewoud Kohl van Wijngaarden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-01-03 00:28:17 UTC
Portage 2.1.7.16 (default/linux/x86/10.0, gcc-4.4.2-asneeded, glibc-2.11-r1, 2.6.32.2 i686)
=================================================================
System uname: Linux-2.6.32.2-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.1
Timestamp of tree: Fri, 01 Jan 2010 16:30:01 +0000
ccache version 2.4 [disabled]
app-shells/bash:     4.0_p35
dev-java/java-config: 1.3.7-r1, 2.1.10
dev-lang/python:     2.6.4, 3.1.1-r1
dev-python/pycrypto: 2.1.0
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.8.0
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.0
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.4_p6-r1, 1.5-r1, 1.6.3-r1, 1.7.9-r2, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openfire/resources/security/ /opt/openjms/config /usr/lib/ccs/conf /usr/lib/fax /usr/share/X11/xkb /usr/share/bufrtables /usr/share/config /usr/share/qpsmtpd/plugins /var/bind /var/lib/hsqldb /var/phxd /var/qmail/alias /var/qmail/control /var/spool/fax/etc /var/spool/torque /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/distfiles"
FEATURES="assume-digests distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo"
INSTALL_MASK="  /usr/share/doc  /usr/share/info"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree-tinderbox"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap ncurses nls nostatic nptl nptlonly openmp pam pcre perl pppd python qt3support readline reflection ruby session spl ssl sysfs tcpd unicode x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest" ELIBC="glibc" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" RUBY_TARGETS="ruby18" USERLAND="GNU"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, LC_ALL, LINGUAS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-01-03 00:28:35 UTC
Created attachment 214971 [details]
Build log
Comment 2 Ewoud Kohl van Wijngaarden 2010-01-29 20:12:20 UTC
Created attachment 217874 [details, diff]
Corrected pysvn-1.7.1-skip_root_test.patch

A corrected patch. The previous patch added nested if statements which seemed to break without a semicolon. I've also added then to the if statement.

Running the test both as normal user and as root now works as expected.

Still, I think a patch that skips a test isn't a really nice patch. The cause of the problem is that `whoami` is replaced by <username>. if you run the test, it attempts to create a SVN repo with testroot-06 as name. You can guess what's replaced and doesn't match the expected result...
Comment 3 Ewoud Kohl van Wijngaarden 2010-01-30 20:06:28 UTC
I've filed http://pysvn.tigris.org/issues/show_bug.cgi?id=147 so hopefully it'll be fixed upstream instead.
Comment 4 Ewoud Kohl van Wijngaarden 2010-01-31 18:14:09 UTC
Copied from pysvn bugzilla:
------- Additional comments from barryscott@tigris.org Sun Jan 31 10:07:37 -0800 2010 -------
I have fixed this on trunk by changing svn_cmd.py to use root_URL not root<SP>URL.
I have also updated the known good results to match.

Fixed committed in r1291 and r1292 on trunk.
------- 

See http://pysvn.tigris.org/source/browse/pysvn?view=rev&revision=1291 and http://pysvn.tigris.org/source/browse/pysvn?view=rev&revision=1292.
Comment 5 Ewoud Kohl van Wijngaarden 2010-02-01 02:19:56 UTC
Created attachment 218046 [details, diff]
A patch to fix the root url problem

svn diff http://pysvn.tigris.org/svn/pysvn/trunk/pysvn/Extension/ -r 1290:1293 > files/pysvn-fix_root_url.patch

Applies to 1.7.2, haven't tested 1.7.1. Note that in revision 1293 a minor correction was applied.
Comment 6 Ewoud Kohl van Wijngaarden 2010-10-21 13:33:54 UTC
It seems 1.7.4 has entered the tree which doesn't need this patch anymore, yet it's still applied. Removing the epatch line from src_prepare should close this bug.
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-23 15:09:04 UTC
pysvn-1.7.1-skip_root_test.patch has been deleted.