| Summary: | x11-libs/gtk+extra doesn't build against gtk+-2.18 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs.gentoo, kutagrob |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 302502 | ||
| Bug Blocks: | 304777, 309347 | ||
| Attachments: |
Build log
Fixes error during compilation New ebuild for release candidate with GTK 2.18 compatibility |
||
|
Description
Diego Elio Pettenò (RETIRED)
2009-11-07 01:34:58 UTC
Created attachment 209497 [details]
Build log
Created attachment 209823 [details, diff]
Fixes error during compilation
I've written this patch which allows to compile successfully.
I have gtk+-2.18.3 installed and in header from this package(/usr/include/gtk-2.0/gtk/gtkentry.h):
x_n_bytes instead of n_bytes
x_text_size instead of text_size
May be that would be helpful.
Your patch looks good, gtk+extra now builds with gtk+-2.18.3 but does it build with gtk+-2.16.6 ? (stable version) No. It doesn't build with 2.16.6 with my patch. So another way of correction will be to downgrade from gtk+-2.18.3 to 2.16.6. Fix sounds quite simple, in /usr/include/gtk-2.0/gtk/gtkitem.h: /*< private >*/ [...] guint16 GSEAL (x_text_size); /* allocated size, in bytes */ guint16 GSEAL (x_n_bytes); /* length in use, in bytes */ so these fields are private and were renamed. Since gtk+extra has had no release since 2005 I wonder if we really want to keep it alive. What do you think guys ? I'd prefer to kill it, but 2 packages depend on it: dev-embedded/gpsim (unconditionally, marked as unmaintained) and dev-php5/php-gtk (optionally, also unmaintained, last touched by us). I've added Samuli for comment, as he last touched gpsim. (In reply to comment #6) > I'd prefer to kill it, but 2 packages depend on it: dev-embedded/gpsim > (unconditionally, marked as unmaintained) and dev-php5/php-gtk (optionally, > also unmaintained, last touched by us). I've added Samuli for comment, as he > last touched gpsim. > Sorry for late response. gpsim is widely used package, but it's main purpose is the command-line interface and libraries, so don't kill the package, if you must, kill the "gtk" USE flag anytime you wish Did it myself :) + 09 Feb 2010; Samuli Suominen <ssuominen@gentoo.org> gpsim-0.24.0.ebuild: + Remove broken and optional GUI wrt #292211. And it's going stable wrt bug 302502 What is the plan on this then? gtk+extra removal or fixing? For fixing it, maybe would be interesting to look at fedora's patch ;-) http://cvs.fedoraproject.org/viewvc/devel/gtk%2Bextra/gtk%2Bextra-2.1.1-gtk2.18.patch?revision=1.1&content-type=text/plain&view=co (In reply to comment #9) > What is the plan on this then? gtk+extra removal or fixing? For fixing it, > maybe would be interesting to look at fedora's patch ;-) > http://cvs.fedoraproject.org/viewvc/devel/gtk%2Bextra/gtk%2Bextra-2.1.1-gtk2.18.patch?revision=1.1&content-type=text/plain&view=co > Sigh! If you decide to fix it, don't forget to open a bug against gpsim to reintroduce the USE="gtk" flag. Masked for removal finally as talk on IRC with Remi I also dropped extra USE flag on dev-php5/php-gtk and seems that gpsim was already fixed by Samuli GPSim is NOT mainly used for command line! And it's not dead by any means! The owner of GPSim upstream (Roy Rankin) has been in contact with the owner of GTK+extra upstream to get himself the access needed to produce the bug fix release. In the mean time, Fedora has a patch against 2.1.1 to make it compatible with GTK2.18 and it would be a great shame if Gentoo ruled itself out of convenience for PIC developers over such trivia. PLEASE DO NOT REMOVE GTK+EXTRA. Fix it instead, or at least keep alive until Roy manages to either fix upstream or fork the bits GPSim needs. The upstream CVS for gtk+-extra now contains a release candidate for 2.1.2 which fixes all the known bugs and builds against GTK+ 2.18 Please reinstate this new version ASAP Please send us an updated ebuild with confirmation that it works for you. Thanks Created attachment 224477 [details]
New ebuild for release candidate with GTK 2.18 compatibility
Here's an ebuild that works for me. I have tested against both GTK2.16 and GTK2.18 and against as-installed and re-built GPSim.
Two notes:
- the ebuild is marked unstable (~x86)
- it calls up the release candidate tarball. Once the proper release is available upstream the URL needs the "rc" removed from after {P}. The release is expected by Wednesday.
The release candidate has been removed from sourceforge, the latest is now gtk+extra-2.1.2.tar.gz Builds fine here with gtk+-2.18.7 +*gtk+extra-2.1.2 (27 Mar 2010) + + 27 Mar 2010; Pacho Ramos <pacho@gentoo.org> -gtk+extra-2.1.1.ebuild, + -gtk+extra-2.1.1-r1.ebuild, -gtk+extra-2.1.1-r2.ebuild, + +gtk+extra-2.1.2.ebuild: + Version bump including gtk+-2.18 and SIGSEGV fixes, documentation added. + Thanks to Robert Pearce and Joop Stakenborg in bug 292211 for their + investigation regarding upstream updates. This also sets GCONF_DEBUG=no + due to missing --enable-debug configure option. Cleaning old versions And sorry for the delay, but gnome team is a bit overloaded. |