| Summary: | xmms-1.2.8-dtd.patch makes xmms-cdread-0.14a finding undefined symbol: playlist_generate_shuffle_list | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | CBke -Left- bye <cbatdotcom> |
| Component: | Current packages | Assignee: | Seemant Kulleen (RETIRED) <seemant> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cbatdotcom, crusaderky, sound, spock, vapier |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
CBke -Left- bye
2003-09-14 18:07:31 UTC
how do you know it's related to the dtd patch ? have you tried emerging xmms-1.2.8-r1 w/out the dtd patch ? I know for sure that it's not the dtd patch. I haven't narrowed down exactly what it is yet, though. From the xmms changelog:
* xmms/playlist.c, xmms/controlsocket.c, xmms/main.c, xmms/util.c:
Every function that modifies the playlist directly calls
playlist_generate_shuffle_list(). Removed calls to this function
from other files.
and note that in playlist.c:
static void playlist_generate_shuffle_list(void);
that's not going to get exported (it's static). In 1.2.7, this was a public symbol, and consequently could be used by cdread:
void playlist_generate_shuffle_list(void)
playlist_generate_shuffle_list();
./xmms/playlist.c
void playlist_generate_shuffle_list(void);
./xmms/playlist.h
I'll take a look and see if there is another function that cdread can call instad. Otherwise it's probably safe to say that cdread won't work with xmms 1.2.8 until a new version is released.
It's a bit of a hack but calling playlist_set_shuffle() instead causes the playlist to get re-shuffled. It's a really simple patch. I'll give it somemore testing and then put back an r1 of xmms-cdread. Commited as -r1, ~x86 masked. Let me know if there are any issues. Thanks. i've just got one question, what's the point in using cdread with xmms 1.2.8 ? as the rewrote cdda plugin in xmms now supports digital extraction too and also supports multiple devices. imo the xmms-cdread ebuild should just be changed to block on xmms >=1.2.8 i know that sounds a bit harsh, it's just the way i see it Good point. I just fixed it because it was fixable and seemant asked me to look at it. It's probably not broken for 1.2.7. Still, if 1.2.8 has the same functionality then perhaps we should do as you suggest. I certainly don't want to end up maintaining the patch. As seemant is more involved w/xmms these days i'll leave the decision up to him. *** Bug 30669 has been marked as a duplicate of this bug. *** |
