| Summary: | dev-db/phpmyadmin-3.2.0.1.ebuild should not depend on mysql | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Fabiano Francesconi <fabiano.francesconi> |
| Component: | [OLD] Development | Assignee: | Gentoo Web Application Packages Maintainers <web-apps> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | phpmyadmin_patch.ebuild | ||
|
Description
Fabiano Francesconi
2009-09-11 14:39:26 UTC
you need mysql for the client library (In reply to comment #1) > you need mysql for the client library > Correct but you don't need it to run phpmyadmin so I think that the ebuild should use RDEPEND="dev-lang/php[mysql,mysqli]" instead of RDEPEND=">=virtual/mysql" Because if you have php without the mysql use flag you can't run phpmyadmin even if you have mysql installed on your system. I'll reopen this, then. (In reply to comment #2) > RDEPEND="dev-lang/php[mysql,mysqli]" > Because if you have php without the mysql use flag you can't run phpmyadmin > even if you have mysql installed on your system. I agree, indeed the dependency on the MySQL's virtual is redundant as the function pkg_setup() just check for the right PHP's USE: mysql, mysqli, injecting all the required MySQL's virtuals. IMHO there is not need to declare RDEPEND="dev-lang/php[mysql,mysqli] unless we get rid of all the calls to require_php_with_* functions and we convert the ebuild to EAPI2. Created attachment 204060 [details]
phpmyadmin_patch.ebuild
I've create an ebuild patch for the phpmyadmin-3.2.0.1 which fix the virtual/mysql dependency. As I wrote before the new ebuild use the EAPI="2" with RDEPEND on dev-lang/php. With this version we don't need the pkg_setup() function because the USE flags for php are listed on the RDEPEND section. The main problem in that if a user change delete the mysqli use flags phpmyadmin doesn't work anymore. I'm sorry for the double post but I realize that I could be more strict in describe why and how I changed the original ebuild. In the previous version with RDEPEND="virtual/mysql" a if a user change the php use flags with -mysql the phpmyadmin package doesn't work anymore. With the EAPI="2" version of the ebuild all these things are handle by portage. The dependency is gone in the new ebuild. (3.3.5.1) |
