Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 281133

Summary: Repoman 2.2_rc36 reports false positives for EbuildBlankLine
Product: Portage Development Reporter: Ulrich Müller <ulm>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal CC: maekke
Priority: High Keywords: InVCS
Version: 2.2   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 210077, 288499    
Attachments: Minimal example
handle indented here-document ending

Description Ulrich Müller gentoo-dev 2009-08-11 18:56:38 UTC
RepoMan scours the neighborhood...
  ebuild.minorsyn               2
   app-editors/emacs/emacs-22.3-r2.ebuild: Useless blank line on last line
   app-editors/emacs/emacs-23.1.ebuild: Useless blank line on last line

The last line of the ebuild is definitely non-empty.
Comment 1 Ulrich Müller gentoo-dev 2009-08-11 18:59:56 UTC
Created attachment 200956 [details]
Minimal example

I've prepared a minimal example that triggers the bug. Looks like it has something to do with here-documents.
Comment 2 Zac Medico gentoo-dev 2009-08-12 08:49:14 UTC
Created attachment 201006 [details, diff]
handle indented here-document ending
Comment 3 Ulrich Müller gentoo-dev 2009-08-12 10:28:23 UTC
(In reply to comment #2)
> Created an attachment (id=201006) [edit]
> handle indented here-document ending

This doesn't fix it.
Comment 4 Ulrich Müller gentoo-dev 2009-08-12 10:34:47 UTC
(In reply to comment #3)
> This doesn't fix it.

Actually, it does. (I applied the patch "by hand" and made a typo).
Sorry for the confusion.
Comment 5 Zac Medico gentoo-dev 2009-08-21 23:17:53 UTC
This is fixed in 2.2_rc39.
Comment 6 Zac Medico gentoo-dev 2009-10-11 01:02:22 UTC
This is fixed in 2.1.7.