| Summary: | [devmanual] update epatch section | ||
|---|---|---|---|
| Product: | Documentation | Reporter: | Mounir Lamouri (volkmar) (RETIRED) <volkmar> |
| Component: | Devmanual | Assignee: | Gentoo Quality Assurance Team <qa> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | Keywords: | Inclusion |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Fixing patch
Fixing patch |
||
Created attachment 197375 [details, diff]
Fixing patch
That patch makes the example not work right anymore. Come up with an example for EAPI 2 if that's what you are going for. (In reply to comment #2) > That patch makes the example not work right anymore. Don't get it. It's not breaking it. (I've just tested it with an EAPI-0 ebuild) Created attachment 204238 [details, diff] Fixing patch I don't see why you think it's breaking. I've attached a new patch with comments to let user understand what's going on. As I said in comment #0, it will help having code EAPI-0 and EAPI-2 compliant as src_prepare is doing unpack ${A}. He means that it should be adjusted to show 2 phases:
src_unpack() {
unpack ${A}
epatch "${WORKDIR}"/Blesmrt.patch
}
or use simply: (since in eapi2 fallback for src_unpack() is unpack ${A})
src_prepare() {
epatch "${WORKDIR}"/Blesmrt.patch
}
Fixed |
Devmanual mentions patch have to be mirrored compressed when too big. It shows an example explaining how using such patch files: unpacking only source then using epatch on the compressed patch. However, with EAPI-2, it's not helping because patch is done in src_prepare so the patch will be in ${WORKDIR} instead of ${DISTDIR}. As the devmanual is mostly EAPI-0 aware, I don't think we should change the example to src_prepare but we should change the example to be EAPI-2 compatible. See the attachment.