Summary: | Bump media-libs/ploticus-2.41 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Peter Alfredsen (RETIRED) <loki_val> |
Component: | New packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | CC: | markus, thomas.kreuzer |
Priority: | High | ||
Version: | 2008.0 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://ploticus.sourceforge.net/doc/download.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ploticus-2.41.ebuild
pl241src.patch ploticus-2.41.ebuild pl241src.patch pl241src.patch ploticus-2.41.ebuild ploticus-2.41.ebuild ploticus-2.41.ebuild |
Description
Peter Alfredsen (RETIRED)
![]() Created attachment 214270 [details]
ploticus-2.41.ebuild
Some changes in ploticus are that there is now only a single Makefile, there is now a .so library (still experimental, and I am ignoring it), and the targets now require EXE to be set individually.
Something that should have been done already: install pl.h into /usr/include.
One more patch to come...
Created attachment 214272 [details, diff]
pl241src.patch
Porting over the ploticus-2.33 patch.
I should also note that I commented out the 'emake ... install' line in the ebuild, instead of removing it.
Created attachment 214274 [details]
ploticus-2.41.ebuild
Whoops. Turns out the 'emake ... install' line was good for something.
Created attachment 214276 [details]
pl241src.patch
...
I thoroughly tested this on the ONE script I have. Your mileage may vary
Created attachment 214283 [details, diff]
pl241src.patch
ffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu
Okay, so now it actually does the linking with X11, SVG, etc. right. I also made sure to check in the Makefile for changed/removed definitions. It passes all the tests in pl241src/pltestsuite/.
One thing that maybe should be done is setting PREFABS_DIR in api.c and preliminaries.c to some defaults (e.g. /usr/share/ploticus/prefabs).
Created attachment 214284 [details]
ploticus-2.41.ebuild
I will stop being a douche bag now. This should totally work.
(as long as I'm adding myself to CC and therefore spamming [many apologies, Daniel], I will again note that the .so library is there but experimental) Created attachment 215358 [details]
ploticus-2.41.ebuild
Whoops. I didn't notice that pl.h includes plg.h. Installing that as well. I have to wonder about the quality of these headers, though. Stuff like this troubles me:
#define X 'x'
#define YES 1
The new ebuild doesn't work for me:
>>> Install ploticus-2.41 into /var/tmp/portage/media-libs/ploticus-2.41/image/ category media-libs
make -j3 INSTALLBIN=/var/tmp/portage/media-libs/ploticus-2.41/image/usr/bin EXE=pl install
cp pl /var/tmp/portage/media-libs/ploticus-2.41/image/usr/bin
cp: cannot stat `pl': No such file or directory
make: *** [install] Error 1
* ERROR: media-libs/ploticus-2.41 failed:
* (no error message)
*
* Call stack:
* ebuild.sh, line 54: Called src_install
* environment, line 2332: Called die
* The specific snippet of code:
* emake INSTALLBIN=${D}usr/bin EXE="${EXE}" install || die;
I found the problem, the above mentioned error only comes when the USE flag "gd" is _not_ enabled. I hope this helps. Created attachment 220389 [details, diff]
ploticus-2.41.ebuild
I think previous ploticus versions ignored the EXE= make option in some cases. Specifying EXE=plnogd used to make an executable called 'pl', but now it writes to 'plnogd'.
Solution: USE=-gd builds change from 'make ... EXE=plnogd plnogd' to 'make ... EXE=pl plnogd'.
Removed from tree. |