Bug 264134

Summary:	media-sound/mp3gain-1.4.6-r2 does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Joshua Rich <joshua.rich>
Component:	Current packages	Assignee:	Tony Vroon (RETIRED) <chainsaw>
Status:	RESOLVED FIXED
Severity:	QA	CC:	sound
Priority:	High
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	patch against mp3gain-1.4.2-r2.ebuild

Description Joshua Rich 2009-03-29 02:36:21 UTC

media-sound/mp3gain-1.4.6-r2, current stable on all keyworded archs does not respect LDFLAGS.  A QA warning is generated when compiling:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/mp3gain

The attached patch fixes this QA issue. Please adjust as necessary!

Thanks and regards,

Joshua Rich

Reproducible: Always

Comment 1 Joshua Rich 2009-03-29 02:38:56 UTC

Created attachment 186616 [details, diff]
patch against mp3gain-1.4.2-r2.ebuild

Comment 2 Joshua Rich 2009-03-29 02:40:51 UTC

(In reply to comment #1)
> Created an attachment (id=186616) [edit]
> patch against mp3gain-1.4.2-r2.ebuild
> 

Apologies, that is a patch against mp3gain-1.4.6-r2.ebuild, my mistake in the version.

Comment 3 Tony Vroon (RETIRED) gentoo-dev

2009-04-16 16:38:48 UTC

+*mp3gain-1.4.6-r3 (16 Apr 2009)
+
+  16 Apr 2009; <chainsaw@gentoo.org> -mp3gain-1.4.6-r1.ebuild,
+  +mp3gain-1.4.6-r3.ebuild:
+  Patch by Joshua Rich to respect LDFLAGS, closes bug #264134. Remove old
+  ebuild.

Your contribution to Gentoo Linux is highly appreciated :)