Summary: | [gnome overlay] net-libs/libproxy-0.2.3 fails to compile with USE=xulrunner | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alois Hammer <aloishammer> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | boltomli, jdaluz, mozilla, mrpouet, pva, sergio.bevilacqua |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://code.google.com/p/libproxy/issues/detail?id=44 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 263083 | ||
Attachments: |
Output
the patch which solves the problem the new ebuild including the patch and restored xulrunner USE flag |
Description
Alois Hammer
2009-02-16 06:26:08 UTC
Created attachment 182202 [details]
Output
Which version of net-libs/xulrunner do you have? 1.9.0.6-r1 (In reply to comment #3) > 1.9.0.6-r1 > xulrunner-js (/usr/lib/pkgconfig/mozilla-js.pc) has only stable API include directory in the .pc file, but the jsapi.h is in unstable dir. plaes@chi ~ $ qlist xulrunner |grep jsapi /usr/include/xulrunner-1.9/unstable/jsapi.h Same problem here. I wrote this fugly patch to include /unstable in the header path search: --- libproxy-0.2.3.ebuild 2009-02-12 02:09:51.000000000 +0100 +++ libproxy-0.2.3.ebuild 2009-02-18 03:40:52.000000000 +0100 @@ -43,6 +43,8 @@ } src_configure() { + sed -i configure -e '/pkg_cv_mozjs_CFLAGS=`$PKG_CONFIG/a pkg_cv_mozjs_CFLAGS="$pkg_cv_mozjs_CFLAGS -I/usr/include/xulrunner-1.9/unstable "' + econf --with-envvar \ --with-file \ --disable-static \ (In reply to comment #4) > xulrunner-js (/usr/lib/pkgconfig/mozilla-js.pc) has only stable API include > directory in the .pc file, but the jsapi.h is in unstable dir. Maybe a mozilla-js-unstable.pc file would be appropriate. Or does Mozilla upstream have other plans? @mozilla: what do you say? I'm also curious as to how libproxy upstream got the idea that mozilla-js.pc gives them what they need.. There is already a libxul-unstable.pc module for pkg-config (in the 1.9.0.8 stable version expect for sparc arch) $ pkg-config libxul-unstable --cflags -fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr normaly jsapi header should be found correctly, i'll have a look to the appropriate configure.[ac|in] to find a issue, and after write a patch to solve the problem ;) please find in attachment the patch which normaly solve the problem, and the new ebuild :) Created attachment 187912 [details, diff]
the patch which solves the problem
Created attachment 187913 [details]
the new ebuild including the patch and restored xulrunner USE flag
Compiles fine, now. Thanks. This isn't in the overlay yet, so no, not fixed. @Alois: you must not mark the bug as resolved if a dev didn't reviewed and approved it ;) PS: i sent an email to the herd gnome containing a git format-patch, to directly integrate this fix into the overlay ;) mrpouet Please open an upstream bug attach this there as well so it gets included in the next release Thanks upstream opened see http://code.google.com/p/libproxy/issues/detail?id=44 ;) thanks guys. net-libs/libproxy-0.2.3-r1 fails to compile against net-libs/xulrunner-1.9.0.11. Looks like the ../unstable bug rears its head again... |