| Summary: | Wrong path check in app-office/openoffice-3.0.0 ebuild in pkg_postinst | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas Sachau <tommy> |
| Component: | New packages | Assignee: | Gentoo Office Team <office> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hardened |
| Priority: | High | ||
| Version: | 2008.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
If you provide a patch to the ebuild for both that would be nice, really don't know anything about the pax-stuff First part is fixed, about the rest: Please reopen if there is some sort of patch, really don't know a thing about pax... This shouldnt be hard: ( [[ -x /sbin/chpax ]] || [[ -x /sbin/paxctl ]] ) && [[ -e /usr/$(get_libdir)/openoffice/program/soffice.bin ]] && scanelf -Xzm /usr/$(get_libdir)/openoffice/program/soffice.bin This is commited now, thanks and sorry for taking ages, seems I've missed your reply ... :-( (In reply to comment #3) > This shouldnt be hard: > > ( [[ -x /sbin/chpax ]] || [[ -x /sbin/paxctl ]] ) && [[ -e > /usr/$(get_libdir)/openoffice/program/soffice.bin ]] && scanelf -Xzm > /usr/$(get_libdir)/openoffice/program/soffice.bin > Is all this really necessary (not positive+haven't checked, really asking)? Why test for chpax and paxctl but then run scanelf? Besides, this won't work, it needs to be -Xxzm at minimum. Why not simply: scanelf -qXxzm /usr/$(get_libdir)/openoffice/program/soffice.bin @openoffice team: Any comment on the suggested simplification from Gordon? Looks ok to me. pax check has been long changed, so closing |
soffice.bin exists in /usr/${libdir}/openoffice/program/ instead of /usr/${libdir}/openoffice/basis3.0/program/. Because of this, the check for pax change fails and is not done. Additionally, i would suggest to check, if either /sbin/chpax or /sbin/paxctl exists, since chpax is deprecated and paxctl should be used instead where possible. And a suggestion from solar: <solar> imo scanelf -Xz perms should be used cuz it does paxctl+chpax perms on an ELF.