Bug 252614

Summary:	[patch] media-libs/svgalib-1.9.25 fails compilation against 2.6.28
Product:	Gentoo Linux	Reporter:	Marco Leogrande <dark.knight.ita>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andriy155, fauli, gengor, ghutzl, j.abaffy, orodruinlair, patrick.hieber, xaviermiller
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	252467
Attachments:	Patch to kernel26compat.h to allow compilation of svgalib-1.9.25 on 2.6.28 ebuild that applies the patch provided above.

Description Marco Leogrande 2008-12-26 16:17:34 UTC

media-libs/svgalib-1.9.25 fails to compile against sys-kernel/gentoo-sources-2.6.28 with the following error:

/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.c: In function ‘init_module’:
/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.c:660: error: implicit declaration of function ‘device_create_drvdata’
  CC [M]  /var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/virtual.o
make[2]: *** [/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper/main.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [_module_/var/tmp/portage/media-libs/svgalib-1.9.25/work/svgalib-1.9.25/kernel/svgalib_helper] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.28-gentoo'
make: *** [default] Error 2

The proposed patch is trivial and involves some more #define hacks about the device_create() function. I simply copied and pasted the macro definition already in place for the 2.6.27 kernel, but I believe I spotted a missing argument (namely, void * drvdata). GCC warned me about the inconsistency and i added a NULL argument: the module compiles fine. I'll test the new kernel + svgalib in minutes.

Comment 1 Marco Leogrande 2008-12-26 16:21:05 UTC

Created attachment 176440 [details, diff]
Patch to kernel26compat.h to allow compilation of svgalib-1.9.25 on 2.6.28

Comment 2 Jeff Wood 2009-01-03 15:52:54 UTC

Created attachment 177228 [details]
ebuild that applies the patch provided above.

This applies the patch provided, and it builds here locally.

Comment 3 Daniel Drake (RETIRED) gentoo-dev

2009-01-09 17:17:40 UTC

patch looks good

Comment 4 Jaroslav Abaffy 2009-01-11 22:10:00 UTC

worked well for me, thanks a lot.

Comment 5 Patrick Hieber 2009-01-27 15:35:32 UTC

how to i apply the patch?

Comment 6 denis 2009-02-05 20:14:46 UTC

(In reply to comment #1)
> Created an attachment (id=176440) [edit]
> Patch to kernel26compat.h to allow compilation of svgalib-1.9.25 on 2.6.28
> 

Hello, when is this patch going to make it into an available package?

Comment 7 Łukasz Damentko (RETIRED) gentoo-dev

2009-02-13 03:01:57 UTC

I had this problem with gentoo-sources 2.6.28-r1 and the attached patch helped me. Thanks.

Comment 8 Christian Faulhammer (RETIRED) gentoo-dev

2009-02-27 12:38:05 UTC

I will fix the ebuild soon.

Comment 9 Christian Faulhammer (RETIRED) gentoo-dev

2009-02-28 00:11:19 UTC

Fix committed to tree.  No revbump as it fixes a build breakage.  Renamed no-kernel USE flag to kernel-helper and make it default.