Bug 250212

Summary:	[patch] repoman marks "emake -j1" as a minor syntax error, when it's syntacically correct and recommended
Product:	Portage Development	Reporter:	Mike Auty (RETIRED) <ikelos>
Component:	Repoman	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	InVCS
Priority:	High
Version:	2.2
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	210077, 216231
Attachments:	Patch for trunk that adds "upstream.workaround" and associated help text

Description Mike Auty (RETIRED) gentoo-dev

2008-12-07 22:07:51 UTC

It's really confusing to be receive an error "ebuild.minorsyn" simply because an ebuild used "emake -j1".  Looking at the repoman help, an ebuild.minorsyn is:
"This ebuild has a minor syntax error that contravenes gentoo coding style".

emake -j1 is neither a syntax error, nor does it contravene gentoo coding style.  In fact, it's recommended (see bug 250141).

As such, I'd suggest a new category "upstream.workaround" with a better description of the problem, suggesting that the text used is in fact a workaround for an upstream bug, and that a bug should be filed upstream and tracked in gentoo's bug tracker.

Comment 1 Mike Auty (RETIRED) gentoo-dev

2008-12-07 22:10:17 UTC

Created attachment 174604 [details, diff]
Patch for trunk that adds "upstream.workaround" and associated help text

This is the first patch I've made for portage, as such I dunno if I managed to make changes in all the appropriate places.  Do feel free to reword it if the wording is awkward or unclear.  This should apply to portage trunk (r12174).  Please let me know if there are any issues with it, or any mistakes, etc.  Thanks...  5:)

Comment 2 Zac Medico gentoo-dev

2008-12-08 03:26:31 UTC

Thanks, your patch is in svn r12179.

Comment 3 Zac Medico gentoo-dev

2008-12-13 00:31:08 UTC

This is in 2.1.6.1.