Bug 248142

Summary:	net-misc/sambasentinel: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED WONTFIX
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log Patch to address numerous QA issues in upstream Makefile

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-22 11:27:26 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-22 11:27:36 UTC

Created attachment 172825 [details]
Build log

Comment 2 Kevin Pyle 2009-02-13 05:15:21 UTC

Created attachment 181833 [details, diff]
Patch to address numerous QA issues in upstream Makefile

The upstream Makefile has several QA violations.  In addition to the --as-needed problem reported above, it does not use user CFLAGS when compiling source files or use user LDFLAGS when linking object files, and it always calls gcc by explicit short name, which will interfere with cross-compiling.

This patch corrects those issues by removing the explicit rules, renaming LIBS to LDLIBS to match the variable used by the implicit GNU make rule, and changing the assignment of INCDIR into an append to CFLAGS.

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-02 12:56:38 UTC

Thanks Kevin, but I think this might be easier to just drop.

Treecleaners, this package still uses gtk 1.2 (and has broken deps); it was added in 2003, never version bumped; a number of minor cleanups.

Comment 4 Kevin Pyle 2009-06-02 15:10:34 UTC

Fine by me.  I only posted the patch because this bug was attached to bug #129413.  I do not use this package.  Based on the lack of activity in bug #240286, I doubt many other people use it either.  The issue raised there has been unfixed since October 2008 and no one seems to be complaining.

Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester

2009-07-11 03:28:35 UTC

Diego, I saw that you were taking care of the masking here in another bug. We will let you manage that and remove treecleaners from this bug. thx

Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-09-09 12:14:27 UTC

Gone.