Bug 247490

Summary:	games-strategy/galaxyhack: fails with forced --as-needed
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	[OLD] Games	Assignee:	Gentoo Games <games>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/qa/asneeded.xml
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	Build log Patch to galaxyhack-1.74.ebuild to amend sed call to fix Makefile

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-18 20:08:02 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-11-18 20:47:07 UTC

Created attachment 172299 [details]
Build log

Comment 2 Kevin Pyle 2009-02-10 04:56:34 UTC

Created attachment 181506 [details, diff]
Patch to galaxyhack-1.74.ebuild to amend sed call to fix Makefile

The upstream Makefile uses LDFLAGS to pass libraries, which is wrong.  This patch changes the sed call to make the Makefile use LDLIBS, which is then added to the link line.

Comment 3 Tupone Alfredo gentoo-dev

2009-02-11 21:35:46 UTC

Fixed in portage. Thanks for report and patches