Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247490 - games-strategy/galaxyhack: fails with forced --as-needed
Summary: games-strategy/galaxyhack: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-11-18 20:08 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-02-11 21:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Build log (games-strategy:galaxyhack-1.74:20081118-195346.log,35.58 KB, text/plain)
2008-11-18 20:47 UTC, Diego Elio Pettenò (RETIRED) 		Details
Patch to galaxyhack-1.74.ebuild to amend sed call to fix Makefile (galaxyhack-as-needed.patch,522 bytes, patch)
2009-02-10 04:56 UTC, Kevin Pyle 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-18 20:08:02 UTC 
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-18 20:47:07 UTC 
Created attachment 172299 [details]
Build log
Comment 2 Kevin Pyle 2009-02-10 04:56:34 UTC 
Created attachment 181506 [details, diff]
Patch to galaxyhack-1.74.ebuild to amend sed call to fix Makefile

The upstream Makefile uses LDFLAGS to pass libraries, which is wrong.  This patch changes the sed call to make the Makefile use LDLIBS, which is then added to the link line.
Comment 3 Tupone Alfredo gentoo-dev 2009-02-11 21:35:46 UTC 
Fixed in portage. Thanks for report and patches