| Summary: | dev-util/xmlindent: CC variable not respected | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | Development Tools Team <dev-tools> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jer |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 243502 | ||
| Attachments: | Patch to xmlindent-0.2.17.ebuild to fix several QA issues | ||
Created attachment 181956 [details, diff]
Patch to xmlindent-0.2.17.ebuild to fix several QA issues
The upstream Makefile ignored CC, CFLAGS, and LDFLAGS because it used a rule which called gcc explicitly and did not refer to either flags variable. This patch modifies the ebuild to export CC as Diego suggested and to add a sed expression which fixes those issues, plus an incorrect dependency rule.
Fixed in -r1. |
I'm filing this bug (from a template, mind you) because the ebuild I'm reporting it against failed to build once I removed my /usr/bin/{gcc,cc,c++,c99} binaries. This means that the ebuild is relying on gcc or cc as compiler, while it should use "$(tc-getCC)" so that user choices are respected, and cross-compiling works as intended. This usually comes down to one of these tasks: - use emake CC="$(tc-getCC)" for building, to ovewrite make's CC variable (defaults to "cc", some upstream rewrites it); - the above plus replacing explicit "gcc" (or similar) calls with $(CC) so that the variable is actually respected; - tc-export CC in src_compile before eventual econf. For C++, you'd have to replace CC with CXX everywhere above, of course. If your package is a special case on this, please let me know. Thanks, Diego