Summary: | media-libs/libopenraw-0.0.5 patch to #include <strings.h> | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Daniel Vergien <daniel.vergien> |
Component: | Prefix Support | Assignee: | Freedesktop bugs <freedesktop-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alt |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Solaris | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
ebuild
adds #include<strings.h> to ljpegdecompressor.cpp updated patch to use cstring instead of strings.h |
Description
Daniel Vergien
2008-10-22 11:56:40 UTC
Created attachment 169400 [details]
ebuild
Created attachment 169402 [details, diff]
adds #include<strings.h> to ljpegdecompressor.cpp
added to the tree, thanks! (In reply to comment #2) > Created an attachment (id=169402) [edit] > adds #include<strings.h> to ljpegdecompressor.cpp > Hi freedesktop team, Would you consider this patch for the gentoo-x86 tree? I have tested it on amd64-linux and it does not cause any problems (and it is needed for x86-solaris). One of the Gentoo Prefix goals is to have as little as possible changes compared to the gentoo-x86 tree. Thanks for your time. (Of course, if you are *strongly* against this patch, that is fine as well. But it is a pretty trivial patch) Hum, you should probably use <cstring> instead of <strings.h> Could you also report the bug upstream and send them your patch? Thanks (In reply to comment #5) > Hum, you should probably use <cstring> instead of <strings.h> Yea, that was already pointed out, slipped my mind.. ;) > Could you also report the bug upstream and send them your patch? bugs.fd.o seems down and I won't be able to work on Gentoo stuff until next week (busy weekend), I won't be offended if someone else gets to it =D Created attachment 170006 [details]
updated patch to use cstring instead of strings.h
Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243 (In reply to comment #8) > Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243 > Upstream has applied this to the git master branch. Could it be applied to gentoo-x86 now? TIA. Committed without a revbump. @Daniel, epatch goes into src_unpack, not src_compile. Just letting you know :) Thanks to the both of you. |