Bug 23272 – ebuild that contains patch which fix cjk's 'preedit string commit problem'

• Product: Gentoo Linux
• Status: RESOLVED LATER

[Description Park Ji-in 2003-06-22 08:36:25 UTC]

when send chat message with uncomplete character by press 'enter' key, it doesnt
send last preedit string(= uncomplete character).
this tarball contain ebuild, and patch (very simple, just 1 line changed  ^.^)

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Park Ji-in 2003-06-22 08:37:18 UTC]

Created attachment 13685 [details]
ebuild.

this is based on gaim-0.63-r1.ebuild

[Comment 2 Park Ji-in 2003-06-22 08:38:00 UTC]

Created attachment 13686 [details, diff]
and patch...

very simple patch :)

[Comment 3 Rainer Größlinger (RETIRED) 2003-06-22 08:39:02 UTC]

*** Bug 23270 has been marked as a duplicate of this bug. ***

[Comment 4 Rainer Größlinger (RETIRED) 2003-06-22 08:40:18 UTC]

thanks for the patch but please don't open 3 equal bugs the next time (I already marked the other two as duplicates, so don't worry ;)

[Comment 5 Brandon Low (RETIRED) 2003-07-14 09:07:56 UTC]

is this still an issue on gaim-0.64?

[Comment 6 Mamoru KOMACHI (RETIRED) 2003-07-15 09:22:21 UTC]

Actually I can't see any problem here. I emerged both gaim-0.64-r2 and
gaim-0.63-r1, but nothing happened when I sent a message with an
incompleted character (using XIM). It just doesn't send any message unless
I complete the character. Moreover, after I patched gaim-0.64-r2 with
the patch (the part of affected source is the same), when I sent an
imcompleted character I got an error:

** (gaim:18123): WARNING **: Invalid change to preedit string, first=0
length=5 (orig length == 0)

What is the exact problem with gaim-0.63 and the expected results with
the patch?

[Comment 7 Park Ji-in 2003-07-17 02:37:19 UTC]

exact problem is that gaim send only committed string exclude preedit string. (all XIM, gtk-im-modules). 

and I dont know about 0.64-r2's error. please explain how to regenerate that error.

[Comment 8 Park Ji-in 2003-07-17 03:15:38 UTC]

Created attachment 14608 [details, diff]
another patch do similar thing

this patch make gaim process key_press_event after
gtk_im_context_filter_key_press().

so the conflict key-binding may work bad, but I think this is better because
imhangul and im-ja also works good.

thanks to Botond Botyanszki from im-ja dev-list.

[Comment 9 Mamoru KOMACHI (RETIRED) 2003-07-17 09:28:31 UTC]

To reproduce the problem, apply your patch (gtk_im_context_reset) to
gaim-0.64-r2 and run gaim, then input some string with your XIM 
(I used skkinput) and press return key _before_ you finish converting
the string. 

btw, should I close this bug since you submitted bug #24657?

[Comment 10 Brandon Low (RETIRED) 2003-07-17 09:32:06 UTC]

Hmm... is the problem you are having still a problem in 0.65 with his patch?  If so I can probably switch it out for your patch w/o too much trouble...

[Comment 11 Park Ji-in 2003-07-17 10:04:47 UTC]

close this bug is better. let's talk on bug #24657.

[Comment 12 Mamoru KOMACHI (RETIRED) 2003-07-17 10:13:43 UTC]

okay, let's move there.