| Summary: | java-utils-2.eclass: java-pkg_doso doesn't make files executable | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | James Le Cuirot <chewi> |
| Component: | [OLD] Java | Assignee: | Java team <java> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bertrand, pesa |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | doso.patch | ||
|
Description
James Le Cuirot
2008-06-10 10:51:59 UTC
Created attachment 156247 [details, diff]
doso.patch
Actually I now notice that dolib defaults to 0644 as well. It's only dolib.so that uses 0755. The point still stands though.
I now also notice that LIBOPTIONS is ineffectively used to set the permissions. I am therefore attaching a fix.
(In reply to comment #1) > > I now also notice that LIBOPTIONS is ineffectively used to set the permissions. > I am therefore attaching a fix. > Isn't the point of LIBOPTIONS to give ebuild writers the ability to control the options? Your patch could then in theory break ebuilds. Yes but dolib.so forces 0755, regardless of LIBOPTIONS. dolib is there for other kinds of files. I can't think of any reason why you wouldn't want a .so file to be exectuble so java-pkg_doso should force it as well. java-pkg_doso() is basically reproducing dolib.so's behaviour, using a different destination directory. Since dolib.so sets LIBOPTIONS="-m0755", I think the proposed patch is correct. (In reply to Davide Pesavento from comment #4) > java-pkg_doso() is basically reproducing dolib.so's behaviour, using a > different destination directory. Since dolib.so sets LIBOPTIONS="-m0755", I > think the proposed patch is correct. Any chances to get this merge ? Merged. |