Summary: | [has patch] tp_smapi fails to compile when KBUILD_OUTPUT is set | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Myk Taylor <myk002> |
Component: | [OLD] Development | Assignee: | Peter Weller (RETIRED) <welp> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anton.bugs, huxiaopengstat, mobile+disabled |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 254043 | ||
Attachments: |
fixes compilation errors
fixes compilation errors for versions 0.31 through 0.37 build.log with the error fix for environments that have KBUILD_OUTPUT set |
Description
Myk Taylor
2008-04-25 18:04:09 UTC
Created attachment 150960 [details, diff]
fixes compilation errors
similar simple patches could be applied to the other tp_smapi ebuilds
Created attachment 150964 [details, diff]
fixes compilation errors for versions 0.31 through 0.37
versions 0.33 and 0.37 didn't need the EXTRA_CFLAGS patch. Patches for all for versions tested successfully on my machine.
Hi, I can't compile the build with your second patch. The error is: /var/tmp/portage/app-laptop/tp_smapi-0.37-r2/work/tp_smapi-0.37/thinkpad_ec.c:37:31: error: linux/thinkpad_ec.h: No such file or directory Please advise. Created attachment 157201 [details]
build.log with the error
ok, the correct patch should be: sed -i 's,EXTRA_CFLAGS := $(CFLAGS),EXTRA_CFLAGS :=,' Makefile the fixed ebuild is in the sectools overlay: http://gentoo.o0o.nu/sectools.xml or http://gentoo.o0o.nu/portage/app-laptop/tp_smapi/ Works for me. *** Bug 238541 has been marked as a duplicate of this bug. *** Created attachment 179731 [details, diff]
fix for environments that have KBUILD_OUTPUT set
The EXTRA_CFLAGS bug was different from what my patch originally addressed. The EXTRA_CFLAGS problem seems to have been fixed in .37 and .39, but there is still a compilation error when KBUILD_OUTPUT is set in make.conf since the ebuild does not correctly use the KV_OUT_DIR variable. The patch fixes this for versions 0.30 through 0.39.
I've also suggested to apply the same patch in the bug #254043 (0.40 version bump) Please mark as "fixed" this bug report since bug #254043 with that patch is in the tree. already fixed. closing. please move your votes. thanks. |