|
Description
Brandon Captain
2008-03-16 19:43:17 UTC
Created attachment 146368 [details]
gmameui-0.1.ebuild
made from the gxmame ebuild probably needs some work
0.2.3 (released 22 June 2008) http://sourceforge.net/project/platformdownload.php?group_id=217857 lol 2.4 Simply renaming the ebuild seems to work for version 0.2.4 Version 0.2.5 is out, too. It builds on PPC, but crashes when ending the "create game list" action. Can anyone reproduce this on x86? Tried 'create game list' in x86, with an old and a clean config, with the old ~/.gmameui It worked just fine although I've been experiencing some crashes, with a clean config I also get a segmentation fault Hi, is it possible to get a gdb backtrace for this? I'm unable to reproduce the segfault when rebuilding the gamelist, and would prefer to fix this as a priority before a new release. well did a backtrace had to learn how to do one as it was my first hope I got it right Created attachment 167028 [details]
backtrace of rebuild game list in 0.2.5
Thanks for adding the stacktrace - it was perfect ;) OK, this looks like a fix I added to CVS did not make it into the release as intended. Can you download the latest version from CVS: In a new directory cvs -d:pserver:anonymous@gmameui.cvs.sourceforge.net:/cvsroot/gmameui login (hit enter) cvs -z3 -d:pserver:anonymous@gmameui.cvs.sourceforge.net:/cvsroot/gmameui co -P gmameui cd gmameui ./autogen.sh && ./configure --enable-debug && make && run Then rebuild the gamelist, and it should not encounter the error. thank you for the quick response, problem solved, rebuild game list now works like a charm with a clean config, I've also tested with an old config and it remains working. Made a CVS ebuild and if you attach a patch to 0.2.5 I'll make a new ebuild applying the patch Created attachment 167098 [details]
gmamui CVS ebuild
Created attachment 167102 [details]
gmameui 0.2.5 ebuild applying rebuild game list fix
Created attachment 167105 [details, diff]
rebuild game list fix
Created attachment 167489 [details]
gmameui 0.2.6 ebuild
Fails to build for me with USE=-nls 0.2.6 builds and here, with NLS flag on. But I still miss menu icons, this is what I get in command line output: (gmameui:24350): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: Key file does not have group 'i386' ** (gmameui:24350): WARNING **: Couldn't find themed icon for "gmameui-view-list" [...] and about 20 more warnings about icons. athlon64 architecture. (In reply to comment #18) > 0.2.6 builds and here, with NLS flag on. But I still miss menu icons, this is > what I get in command line output: > > (gmameui:24350): GLib-WARNING **: GError set over the top of a previous GError > or uninitialized memory. > This indicates a bug in someone's code. You must ensure an error is NULL before > it's set. > The overwriting error message was: Key file does not have group 'i386' > > ** (gmameui:24350): WARNING **: Couldn't find themed icon for > "gmameui-view-list" > [...] > > and about 20 more warnings about icons. athlon64 architecture. > well this is one of my first ebuilds and I could use some help to tune it up I guess there are some dependencies missing from the ebuild, are you using gnome? I don't get those errors maybe it needs gnome, hicolor or tango icon themes which I have installed If you disable NLS support gmameui fails to build if libgnome support is enabled, which is by default, I'm uploading a new ebuild that disables libgnome if nls is disabled Created attachment 168210 [details]
gmameui 0.2.6 ebuild fix -nls not building
ebuild fixing building problem when nls is disabled
Hi, I'll be glad to try to help. I posted about the missing icons, I investigated a bit with strace and here's what I've found. I do not use Gnome as a DE, but I have some components installed, including a couple of icon themes. Gmameui looks for icons in the standard places (/home and /usr/share), and finds them, I guess that's why the more common icons do show up in the application (the new icon which starts a game, the Properties icon and the Refresh icon). Gmame ui then looks for a bunch of other PNG icons in the "/usr/share/games/gmameui/" directory, not finding them. It's not surprising that the application fails to find them, since they do not exist, not in the mentioned directory nor in the source tarball. Also, it seems pretty obvious that at least some of them are custom icons which couldn't be found in a standard theme, but should ship with the application. At this point, I would define this an upstream bug, although a weird one. I guess we could just try to match the referenced icons to some found in Gnome themes and copy or symlink them, as a workaround. Attached above is an extract of strace. Created attachment 168328 [details]
Gmameui strace extract regarding icons
Gmameui strace extract to show that the application tries to open non-existing PNG icon files.
Created attachment 186922 [details]
Version 0.2.7 ebuild
This ebuilds is updated to version 0.2.7 and it also fixes a few problems of the last ebuild:
* Added dependency for app-text/gnome-doc-utils
* Fixed sysntax error in the RDEPEND line (missing whitespace).
* Changed --with-sdlmame-dir to --with-xmame-dir as it's the correct name for this option.
This version crashes for me, though.
It is failing on ~amd64 strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment usr/games/bin/gmameui ecompressdir: bzip2 -9 /usr/share/man * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * callbacks.c:173: warning: implicit declaration of function 'mame_rominfo_dialog_new' * mame_options_dialog.c:130: warning: implicit declaration of function 'strcmp' * * QA Notice: Package has poor programming practices which may compile * but will almost certainly crash on 64bit architectures. * * Function `mame_rominfo_dialog_new' implicitly converted to pointer at callbacks.c:173 * * Please file a bug about this at http://bugs.gentoo.org/ * with the maintaining herd of the package. * * * ERROR: games-emulation/gmameui-0.2.7 failed. * Call stack: * misc-functions.sh, line 729: Called install_qa_check * misc-functions.sh, line 421: Called die * The specific snippet of code: * die "poor code kills airplanes" * The die message: * poor code kills airplanes * * If you need support, post the topmost build error, and the call stack if relevant. * A complete build log is located at '/var/tmp/portage/games-emulation/gmameui-0.2.7/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/games-emulation/gmameui-0.2.7/temp/environment'. * This ebuild is from an overlay named '<UnTraC>': '/usr/local/portage/' * !!! post install failed; exiting. does it really rdep on app-text/gnome-doc-utils? Seems odd. 0.2.9 (released 5 June 2009) Hi. There is a new release available: 0.2.12 (October 2009) (In reply to comment #28) > Hi. > > There is a new release available: 0.2.12 (October 2009) > There is a working ebuild for 0.2.12 in the roslin overlay. I also have one in my local overlay, but the roslin one seems more sane. :) *** Bug 351381 has been marked as a duplicate of this bug. *** Error emerging in Sabayon 64 bits: make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 emake failed * ERROR: games-emulation/gmameui-0.2.12 failed (compile phase): * died running emake, base_src_make * * Call stack: * ebuild.sh, line 85: Called src_compile * environment, line 2339: Called games_src_compile * environment, line 1329: Called base_src_make * environment, line 382: Called die * The specific snippet of code: * emake "$@" || die "died running emake, $FUNCNAME"; * * If you need support, post the output of `emerge --info '=games-emulation/gmameui-0.2.12'`, * the complete build log and the output of `emerge -pqv '=games-emulation/gmameui-0.2.12'`. * This ebuild is from an overlay named 'sabayon': '/var/lib/layman/sabayon/' * The complete build log is located at '/var/tmp/portage/games-emulation/gmameui-0.2.12/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/games-emulation/gmameui-0.2.12/temp/environment'. * Working directory: '/var/tmp/portage/games-emulation/gmameui-0.2.12/work/gmameui-0.2.12' * S: '/var/tmp/portage/games-emulation/gmameui-0.2.12/work/gmameui-0.2.12' >>> Failed to emerge games-emulation/gmameui-0.2.12, Log file: >>> '/var/tmp/portage/games-emulation/gmameui-0.2.12/temp/build.log' * Messages for package games-emulation/gmameui-0.2.12: * ERROR: games-emulation/gmameui-0.2.12 failed (compile phase): * died running emake, base_src_make * * Call stack: * ebuild.sh, line 85: Called src_compile * environment, line 2339: Called games_src_compile * environment, line 1329: Called base_src_make * environment, line 382: Called die * The specific snippet of code: * emake "$@" || die "died running emake, $FUNCNAME"; * * If you need support, post the output of `emerge --info '=games-emulation/gmameui-0.2.12'`, * the complete build log and the output of `emerge -pqv '=games-emulation/gmameui-0.2.12'`. * This ebuild is from an overlay named 'sabayon': '/var/lib/layman/sabayon/' * The complete build log is located at '/var/tmp/portage/games-emulation/gmameui-0.2.12/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/games-emulation/gmameui-0.2.12/temp/environment'. * Working directory: '/var/tmp/portage/games-emulation/gmameui-0.2.12/work/gmameui-0.2.12' * S: '/var/tmp/portage/games-emulation/gmameui-0.2.12/work/gmameui-0.2.12' Created attachment 340690 [details]
gmameui ebuild for version 0.2.12 with new patches added
I have created two new patch files and updated the gmameui 0.2.12 ebuild from the sabayon overlay accordingly. I attach the new ebuild file and three patches in total.
gmameui-0.2.12.ebuild
gmameui-datadir.patch
gmameui-gmameui.c.patch
gmameui-gmameui-zip-utils.c.patch
Created attachment 340692 [details, diff]
first of three patch files for 0.2.12 ebuild
Created attachment 340694 [details]
second of three patch files for 0.2.12 ebuild
Created attachment 340696 [details, diff]
third of three patch files for 0.2.12 ebuild
Code seems to have bitrotten again. Compilation fails with:
In file included from gmameui.c:40:0:
io.h:36:1: error: conflicting types for ‘g_key_file_save_to_file’
g_key_file_save_to_file(GKeyFile *kf, const gchar *file);
^
In file included from /usr/include/glib-2.0/glib.h:55:0,
from /usr/include/glib-2.0/gobject/gbinding.h:28,
from /usr/include/glib-2.0/glib-object.h:23,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
from /usr/include/gtk-2.0/gdk/gdk.h:32,
from /usr/include/gtk-2.0/gtk/gtk.h:32,
from common.h:32,
from gmameui.c:24:
/usr/include/glib-2.0/glib/gkeyfile.h:97:11: note: previous declaration of ‘g_key_file_save_to_file’ was here
gboolean g_key_file_save_to_file (GKeyFile *key_file,
^
|
