Summary: | x11-apps/xdm-1.1.7 installs in /@DESTDIR@ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sandro Bonazzola <sandro.bonazzola> |
Component: | New packages | Assignee: | Gentoo X packagers <x11> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cbm, coldwind, funtoos, HappyFool, ikelos, markusle, mmokrejs, patrizio.bassi, sergey.dryabzhinsky, Sergiy.Borodych |
Priority: | High | Keywords: | Inclusion |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Fix dumb inclusion
Remove all DESTDIR Ebuild update |
Description
Sandro Bonazzola
2008-03-11 21:11:57 UTC
Here is a patch to solve the issue. --- xdm-1.1.7/Makefile.am 2008-03-07 23:03:25.000000000 +0100 +++ /tmp/xdm-1.1.7/Makefile.am 2008-03-12 19:02:46.736574000 +0100 @@ -151,7 +151,7 @@ # App default files (*.ad) -appdefaultdir = @DESTDIR@@appdefaultdir@ +appdefaultdir = ${DESTDIR}@appdefaultdir@ APPDEFAULTFILES = Chooser Hello Is there anybody in there? Just nod if you can here me Is there any dev at home reading this? I've emerged this three days ago. Nobody had hit this one yet? Huh, that's weird. I'm adding the Inclusion keyword to note that this bug contains a fix. I hit the same problem last night - rather strange. Created attachment 146124 [details, diff]
Fix dumb inclusion
Some fixup... but I thunk that we need here to run eautoreconf...
I dont think the DESTDIR entry should be in there at all, that should be handled automatically later. If you remove @DESTDIR@ or $(DESTDIR) and set SNAPSHOT="yes", does it work? Yes, it's work. Created attachment 146270 [details, diff]
Remove all DESTDIR
Remove all DESTDIR entries
Created attachment 146271 [details, diff]
Ebuild update
Set SNAPSHOT="yes" and add patch
(In reply to comment #8 and #9) Attached patches works fine for me. Anyone? There's a fix attached to this bug but no one added it to portage. Is there something wrong? I mean, something beyond Gentoo? Can we help in some form or another? (In reply to comment #12) > There's a fix attached to this bug but no one added it to portage. > Is there something wrong? I mean, something beyond Gentoo? Can we help in some > form or another? It's not clear to me which fix (if either) is correct. This needs to get figured out, rather than just adding something that works, so that the fix can go upstream. (In reply to comment #13) > It's not clear to me which fix (if either) is correct. This needs to get > figured out, rather than just adding something that works, so that the fix can > go upstream. Using patch submitted with comment #8 and comment #9 works for me as stated in comment #10. I can understand that it's better study it better before send it upstream, but if this can't be fixed until then, then mask the package until it's fixed. Having to search in bugzilla for finding a patch and apply manually the patch for having it working doesn't seem either a good thing from my point of view. This is just an opinion, not a criticism. (In reply to comment #8) > Created an attachment (id=146270) [edit] > Remove all DESTDIR > > Remove all DESTDIR entries > Does work for me too. I'm curious why patch isn't included in official portage. I don't suppose someone could commit a temporary fix for this, perhaps just in postinstall? While it's getting pushed upstream? Without a new -r version if need be? If nothing else, it demonstrates a huge QA issue in gentoo. After that gentoo is dying scare last year.. Package that everybody not running a server will have installed, creates a new root-level directory.. (In reply to comment #16) > If nothing else, it demonstrates a huge QA issue in gentoo. After that gentoo > is dying scare last year.. Package that everybody not running a server will > have installed, creates a new root-level directory.. There are reasons it's not marked stable... if you use testing, you can't expect perfection, especially in little things that really don't matter functionally. *** Bug 222493 has been marked as a duplicate of this bug. *** no news here? I see in x11-apps/xdm-1.1.8 for me all OK try it tried 1.1.8, it's ok. this bug can be closed (In reply to comment #21) > tried 1.1.8, it's ok. this bug can be closed Confirm... Thanks for waiting till it got fixed upstream and testing to confirm, folks. |