| Summary: | [PATCH] Fix "zing" symbols for protected config files skipped because they were previously merged | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Russell Yanofsky <rey4> |
| Component: | Core | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 216231 | ||
| Attachments: | confmem-zing-fix.patch | ||
Created attachment 145092 [details, diff]
confmem-zing-fix.patch
fixed, and changed the symbol to '---' as I don't think this deserves a special one. This is supposed to be fixed in portage-2.2_pre5 or earlier. This is supposed to be fixed in portage-2.2_pre5 or earlier. |
When the --noconfmem option is not specified, portage skips the creation of ._cfg####_ files when their checksums are already in the CONFIG_MEMORY_FILE list (/var/lib/portage/config). The problem is that current versions of portage don't give any indication that they are skipping these files. The attached patch fixes the "zing" symbols for these files so install output for these files looks like: -o- /etc/some/conf/file instead of: >>> /etc/some/conf/file This appears to have been the original intention of the code in the dblink.mergeme function, but there's an extra line in there that overwrites the "-o-" symbol right before it is printed. The patch removes this line of code since it is not correct for this case and is redundant for every other case. Reproducible: Always Steps to Reproduce: This problem can be reproduced for pretty much any package with a configuration file. The steps below use the net-misc/rsync package as an example. 1. Emerge net-misc/rsync 2. Edit the /etc/rsyncd.conf file so its checksum changes 3. Emerge net-misc/rsync again. Actual Results: Output from the final merge step will show: >>> /etc/rsyncd.conf This happens even though the /etc/rsyncd.conf merge was skipped (no ._cfg file created). Expected Results: Since it skipped the file, portage should have printed: -o- /etc/rsyncd.conf This is the result you see after applying the patch.