Summary: | gnome-base/nautilus-2.20.0 sound preview not working | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sebastian Kannengießer <sge1899> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | magowiz, micheleschi, pacho |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 214260 | ||
Bug Blocks: |
Description
Sebastian Kannengießer
2007-10-23 18:39:06 UTC
So, I went to test this, and I get no sound preview no matter what I do, with or without the patch. What exactly am I supposed to do to get sound preview? Hover my mouse over an mp3 in nautilus? Select it? What? (In reply to comment #1) > So, I went to test this, and I get no sound preview no matter what I do, with > or without the patch. What exactly am I supposed to do to get sound preview? > Hover my mouse over an mp3 in nautilus? Select it? What? > When you move your mouse over an audio file icon, without clicking on it There is a patch and more info in: http://bugzilla.gnome.org/show_bug.cgi?id=486827 Thanks for pointing me to that bug; I'll see about getting gstreamer preview in. However, looking at the code, I don't see how esound preview can possibly work in 2.20.0, even unpatched. It hardcodes the define for USE_OLD_AUDIO_PREVIEW, which should disable esound preview, no matter what. Color me confused... Okay, I've committed nautilus-2.20.0-r1, which has the new totem/gstreamer sound preview; however, it only has it if you give -esd. I was unable to test the esd sound preview, for lack of a box with working esd. I'm tempted to remove potential esd support in nautilus at all, but I'll wait on feedback for the new preview systems. (In reply to comment #5) There is nothing at all wrong with esd support in nautilus-2.20.0 if, as i said before, you leave away that noesd patch, which incorporates all that defines. Anyway, I'm glad, you added gstreamer support as the redhat people did. I *did* take out the esd patch when testing, and could not get esound support working. And, as I said, I looked at the code, and esound support cannot be enabled, even without the patch. I think what you must have been seeing was not the esound support, but rather the old direct play via mpg123 and ogg123. (In reply to comment #7) > I *did* take out the esd patch when testing, and could not get esound support > working. And, as I said, I looked at the code, and esound support cannot be > enabled, even without the patch. I think what you must have been seeing was > not the esound support, but rather the old direct play via mpg123 and ogg123. > I don't have gnome 2.20 yet, but, for using sound preview with esd, you have to enabled esd and, also, set to ESD from Autodetect on first tab in gnome-sound-properties (In reply to comment #7) Actually, you are partly right. I am previewing files using mpg123, but esound is a "must have" in my case. When shutting down esound, preview does no longer work, which means that nautilus code is in need for esound, which is what the nautilus guys told me as well, in order to preview. What do you actually mean by "esound support cannot be enabled" ? You are definitely right as far as mpg123 is not using esd to output sound, but this method is anyway in need for esd. I mean that the preview code in nautilus that uses esound cannot ever be enabled at compile time, without my patch. It is forced off, and the alternative (using mpg123/ogg123) is forced on. So, adding my patch presumably breaks your preview because it *does* enable esound, rather than because it *doesn't* enable esound. (In reply to comment #5) > Okay, I've committed nautilus-2.20.0-r1, which has the new totem/gstreamer > sound preview; however, it only has it if you give -esd. I was unable to test > the esd sound preview, for lack of a box with working esd. > > I'm tempted to remove potential esd support in nautilus at all, but I'll wait > on feedback for the new preview systems. > About new preview systems, I am using totem way now and works fine :-D, I dropped esd and upgrade to gnome-2.20 and all works ok :-) just to confirm, as far as my test goes, it's not possible to make nautilus to play anything with esd use flag enabled. I suggest we drop this flag and go the gstreamer way. Maybe one day, someone will provide a pulseaudio patch that will make its way upstream to replace this piece of dead code. Sound preview works fine in 2.22. the esound dep is just left-over cruft that has been finally removed in 2.23. Ok, so sound preview in nautilus 2.22 still works fine as long as gstreamer is properly configured. Closing FIXED. And for the record, the "esd" USE flag has been completely removed from nautilus 2.23/2.24 (yay!) |