Summary: | taylor-uucp violates FHS and doesn't supply a single example config | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stefan Förster <gentoo> |
Component: | [OLD] Server | Assignee: | Ryan Phillips (RETIRED) <rphillips> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | agriffis, zul |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Proposed ebuild modifications.
Makefile patch policy.h patch updated ebuild Logging to /var/log/uucp is better than /var/spool/uucp/Log et al. Fixed ebuild. Fixed policy.h patch. Fixed policy.h patch. Changes uucp shell to /bin/bash Typo in ebuild |
Description
Stefan Förster
2003-04-11 05:10:32 UTC
Created attachment 10535 [details]
Proposed ebuild modifications.
Created attachment 10536 [details, diff]
Makefile patch
Hi, This is my propoaded changes to the taylor-uucp ebuild. I hade added a patch which modifies the Makefile. I have also changed the src_compile to do a simeple configure and make. I have hardly touch the src_install but i did add the line to copy the sample directory to /etc/uucp. The sample directory contains sample configuration files. Regards Chuck aka Zul This looks quite good and works for me so far, but I still miss the changes to policy.h which make the package spool to /var/spool/uucp and /var/spool/uucppublic, not /usr/spool/[...] by default. Shouldn't we rather modify policy.h to get default locations of logs and spool data changed than modifying the Makefile/eBuild? If we do not modify policy.h, I think we should change the manpage of "man hier" and remove the UUCP section from there. Created attachment 10547 [details, diff]
policy.h patch
This patch fixes the policy.h file.
This looks very good to me and works completely flawless. Well, almost - it seems that baselayout (or whatever package is responsible for that) does not create the necessary directories /var/spool/uucp, /var/spool/uucppublic and and /var/log/uucp. But I don't know exactly if this is something related to baselayout, or if it should be done by the ebuild of taylor-uucp. Thank you for your efforts, Chuck. Created attachment 10607 [details]
updated ebuild
Creates the /var/spool directories et al.
Created attachment 10619 [details]
Logging to /var/log/uucp is better than /var/spool/uucp/Log et al. Fixed ebuild.
Created attachment 10620 [details, diff]
Fixed policy.h patch.
Logging to /var/log/uucp/
Created attachment 10621 [details, diff]
Fixed policy.h patch.
Logging to /var/log/uucp/.
Sorry for that double post. I missed that your patch to policy.h and the ebuild logged to /var/spool/[...] instead of /var/log/uucp, I fexied that. So, one last thing remains: Shouldn't we include a chsh command to change uucp's shell from /bin/false or /bin/true to /bin/bash, just for the sake of consistency? If a uucp package is installed, you should be able to use the correspondig user. I hope weg got the permissions straight, I didn' want to delete all the folders on my system, but /var/spool/uucp* and /var/log/uucp should be 775 for uucp:root, shouldn't they? (or perhaps 755). Created attachment 10933 [details]
Changes uucp shell to /bin/bash
This is the updated ebuild which modifies the uucp user shell to /bin/bash.
- chuck
Created attachment 10945 [details]
Typo in ebuild
Typo in ebuild.
ryan's back from hiatus so giving this to him thanks for the hard work, chuck Ryan, are you going to be able to make progress on this soon? Thank you Chuck on your great work... Committed. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8a96f916dc3adb981ccc09bc3a59fe3e5112698 commit c8a96f916dc3adb981ccc09bc3a59fe3e5112698 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2023-10-05 19:55:25 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2023-10-05 19:56:34 +0000 net-misc/taylor-uucp: drop usermod calls If a specific shell is required for the uucp user, it must be handled in acct-user/uucp and/or sys-apps/baselayout. Bug: https://bugs.gentoo.org/19128 Closes: https://bugs.gentoo.org/915215 Signed-off-by: Mike Gilbert <floppym@gentoo.org> .../{taylor-uucp-1.07-r5.ebuild => taylor-uucp-1.07-r6.ebuild} | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) |