Summary: | mozilla-*: please base the default language on the user's selected locale, not on $LINGUAS. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Harald van Dijk (RETIRED) <truedfx> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | anmaster, chrb, daniel.tourde, micheleschi, nlshep |
Priority: | High | ||
Version: | 2006.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | mozilla-firefox-linguas.patch |
Description
Harald van Dijk (RETIRED)
2007-06-15 21:18:55 UTC
Created attachment 122194 [details, diff]
mozilla-firefox-linguas.patch
As an added bonus, the whole linguas function can be dropped.
(And a side note, the changed LANGS line is because the fy-NL and pt-PT translations contain malformed install.rdf files. This means they don't work and even break other translations.)
Shrug, i've added that to all the ebuilds, and if the user disables that variable, the product will use the locale instead of the selected locale through the config. Let me explain, if the user has set this in his profile: user_pref("general.useragent.locale", "cs-CZ"); user_pref("intl.locale.matchOS", false); But in the default prefs it's set: pref("intl.locale.matchOS", true); It will ignore the user pref, so i guess it's not funny to have the user forced to change the locale for the app...would be more easy if you could change the language from inside the app(which you already can do, modifiying the config) Plus: https://bugzilla.mozilla.org/show_bug.cgi?id=331779 So yeah, i guess i'll revert it... (In reply to comment #2) > It will ignore the user pref, so i guess it's not funny to have the user forced > to change the locale for the app...would be more easy if you could change the > language from inside the app(which you already can do, modifiying the config) As a workaround (firefox takes a long time to re-emerge), it is possible to start firefox with the -UILocale option to bypass the config. I agree the problem you found is a serious one, and that this is better disabled again at least until user prefs are respected. Still, could you do something to make LINGUAS="*" behave more sanely? Perhaps not changing the default language at all would be an idea? It looks as though the locale has to be specified at build time to get everything correct. I posted a patch in bug #189647. I'm not sure if it's even possible to build for more than one locale (there are no multi-locale binary versions of firefox for download), so I agree it might be best to just get rid of $LINGUAS and that whole linguas function and just use the locale. *** Bug 198085 has been marked as a duplicate of this bug. *** *** Bug 212780 has been marked as a duplicate of this bug. *** Reopening. This is not an upstream bug. The bug is in the ebuild. "Give me all languages" does not mean "change the default language to Afrikaans" (actually, it's now Belarusian here), and it's not upstream that's doing that, it's you. The only upstream bug is that one possible fix doesn't actually work. That shouldn't prevent other fixes.
> Still, could you do
> something to make LINGUAS="*" behave more sanely? Perhaps not changing the
> default language at all would be an idea?
Although I still believe this is a valid bug, I no longer care about this, as I will no longer be using firefox (or any other mozilla products) now that it requires acceptance of an EULA. If you want to close this, feel free. If you want to keep it open, that's fine too. *** Bug 249075 has been marked as a duplicate of this bug. *** Same issue with firefox 3.0.5. Of course, it is always possible to call firefox using the '-UILocale <locale>' flag to get the right language... However, I am not so sure that's the correct way to solve that... :( Daniel i solved with package.use more /etc/portage/package.use | grep mozilla-firefox www-client/mozilla-firefox -linguas_es_ES -linguas_en_GB -linguas_es i have this in make.conf LINGUAS="it it_IT en en_US en_GB es es_ES" Harald if your still interested in this please update patch against latest tree and I will review it, if you no longer are interested please close bug wontfix. (In reply to comment #12) > Harald if your still interested in this please update patch against latest tree > and I will review it, if you no longer are interested please close bug wontfix. I forgot about this because matchOS is currently already enabled by default; there's nothing more to do here. Thanks for the reminder :) |