Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 152615

Summary: git.eclass uses deprecated git-tar-tree
Product: Gentoo Linux Reporter: Avuton Olrich <avuton>
Component: EclassesAssignee: Fernando J. Pereda (RETIRED) <ferdy>
Status: RESOLVED FIXED    
Severity: minor    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 159822    
Bug Blocks:    

Description Avuton Olrich 2006-10-23 19:01:59 UTC
Used in the git-eclass:

 *    committish: master
*** git-tar-tree is now deprecated.
*** Running git-archive instead.
*** 'git-archive' '--format=tar' 'master'

Just a FYI, thanks.
Comment 1 Avuton Olrich 2006-10-23 20:45:30 UTC
Well, the diff is obviously simple enough.

--- /usr/portage/eclass/git.eclass      2006-09-11 01:46:09.000000000 -0700
+++ git.eclass  2006-10-23 12:29:06.334073040 -0700
@@ -226,7 +226,7 @@

        # export to the ${WORKDIR}
        mkdir -p "${S}"
-       git tar-tree ${EGIT_TREE} | ( cd "${S}" ; tar xf - )
+       git archive --format=tar ${EGIT_TREE} | ( cd "${S}" ; tar -xf - )
        echo

 }
Comment 2 Fernando J. Pereda (RETIRED) gentoo-dev 2006-10-24 00:20:07 UTC
And that will fail horribly for people running stable, so we have to keep it that way for a while.

I'll leave this one open and assigned to me so I remember to fix it once the 1.4.3 series goes to stable.

Thanks anyway.

- ferdy
Comment 3 Fernando J. Pereda (RETIRED) gentoo-dev 2007-01-03 01:48:31 UTC
Once bug #159822 is resolved, we can high the dependency on git.eclass and start using git-archive instead of git-tar-tree.

- ferdy
Comment 4 Luca Marturana 2007-04-19 11:09:29 UTC
(In reply to comment #3)
> Once bug #159822 is resolved, we can high the dependency on git.eclass and
> start using git-archive instead of git-tar-tree.
> 
> - ferdy
> 

git-1.5* is stable on all arches, only mips has 1.4* that want the new command too.
Comment 5 Fernando J. Pereda (RETIRED) gentoo-dev 2007-04-19 11:24:13 UTC
Acording to git, archive was introduced after 1.4.2, they have 1.4.1.1 stabled, so this will have to wait. Unless I'm missing something.

It is not such a big deal, since the old way still works perfectly.

Thanks for reminding me, though :)

- ferdy
Comment 6 Fernando J. Pereda (RETIRED) gentoo-dev 2007-04-24 16:37:39 UTC
Committed. Thanks.

- ferdy