| Summary: | eject incorrectly handles mount points with spaces in name | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Adam Goossens <adam.goossens> |
| Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo-bugzilla, matrixhax0r |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
fixes space handling
eject-2.1.5-handle-spaces.patch |
||
|
Description
Adam Goossens
2006-10-13 21:20:07 UTC
Created attachment 99632 [details, diff]
fixes space handling
Created attachment 99676 [details, diff]
eject-2.1.5-handle-spaces.patch
i dont really like that Debian patch ... try this one instead
Thanks - new patch works fine for me. 2.1.5-r1 in portage with patch *** Bug 158252 has been marked as a duplicate of this bug. *** *** Bug 166825 has been marked as a duplicate of this bug. *** Reopen wrt Bug 166825 Relevant information from closed bug (thanks for re-opening Jakub): The patch does not resolve the problem in my opinion. De-mangling of the mount points must be done *before* the strcmp(), not afterwards. Additionally, I would suggest testing for "\0nn" when looking for an octal number rather than testing for "\nnn". Suggested patch: http://bugs.gentoo.org/attachment.cgi?id=110163&action=view It looks like this bug is still around... just encountered it today. The patch (http://bugs.gentoo.org/attachment.cgi?id=110163&action=view) mentioned by Jan seems to fix it for me. So what's the status on this one? This bug is still here, 6 years after reporting. (In reply to comment #10) > So what's the status on this one? This bug is still here, 6 years after > reporting. The status might be changed or chaging since eject moved to be part of sys-apps/util-linux starting from version >= 2.22 Trying to fix sys-apps/eject is a lost cause at this point, but if you can verify the bug in util-linux's version of eject, then we have chances of getting this fixed... I tried building util-linux-9999 but it fails: CCLD test_blkid_cache libblkid/src/test_blkid_cache-cache.o: In function `blkid_get_cache_filename': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:113: undefined reference to `safe_getenv' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:115: undefined reference to `blkid_strdup' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:117: undefined reference to `blkid_strdup' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:119: undefined reference to `blkid_read_config' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:125: undefined reference to `blkid_free_config' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:121: undefined reference to `blkid_strdup' libblkid/src/test_blkid_cache-cache.o: In function `blkid_get_cache': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:162: undefined reference to `blkid_read_cache' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:158: undefined reference to `blkid_strdup' libblkid/src/test_blkid_cache-cache.o: In function `blkid_put_cache': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:178: undefined reference to `blkid_flush_cache' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:188: undefined reference to `blkid_free_dev' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:203: undefined reference to `blkid_free_tag' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:205: undefined reference to `blkid_free_tag' libblkid/src/test_blkid_cache-cache.o: In function `blkid_gc_cache': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/cache.c:233: undefined reference to `blkid_free_dev' CCLD test_blkid_config collect2: error: ld returned 1 exit status make[2]: *** [test_blkid_cache] Błąd 1 make[2]: *** Oczekiwanie na niezakończone zadania.... libblkid/src/test_blkid_config-config.o: In function `parse_next': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:105: undefined reference to `blkid_debug_mask' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:99: undefined reference to `blkid_strdup' libblkid/src/test_blkid_config-config.o: In function `parse_evaluate': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:53: undefined reference to `blkid_debug_mask' libblkid/src/test_blkid_config-config.o: In function `parse_next': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:74: undefined reference to `blkid_debug_mask' libblkid/src/test_blkid_config-config.o: In function `blkid_read_config': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:128: undefined reference to `blkid_debug_mask' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:139: undefined reference to `blkid_debug_mask' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:133: undefined reference to `blkid_debug_mask' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:119: undefined reference to `safe_getenv' /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:151: undefined reference to `blkid_strdup' libblkid/src/test_blkid_config-config.o: In function `main': /var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999/libblkid/src/config.c:181: undefined reference to `blkid_init_debug' collect2: error: ld returned 1 exit status make[2]: *** [test_blkid_config] Błąd 1 make[2]: Opuszczenie katalogu `/var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999' make[1]: *** [all-recursive] Błąd 1 make[1]: Opuszczenie katalogu `/var/tmp/portage/sys-apps/util-linux-9999/work/util-linux-9999' make: *** [all] Błąd 2 emake failed (In reply to comment #12) > I tried building util-linux-9999 but it fails: > Unrelated to this ticket. Try to build a stable or ~arch version and not -9999 (In reply to comment #13) > (In reply to comment #12) > > I tried building util-linux-9999 but it fails: > > > > Unrelated to this ticket. Try to build a stable or ~arch version and not > -9999 I agree, this bug should not be for resolving building errors with util-linux. Separate bug, forums or IRC might be better suitable for such. But I did ask him to test version above 2.22 :-) (In reply to comment #13) > (In reply to comment #12) > > I tried building util-linux-9999 but it fails: > > > > Unrelated to this ticket. Try to build a stable or ~arch version and not > -9999 There is no stable or ~arch >=util-linux-2.22 eject in util-linux seems to work fine for me
sudo mount /dev/cdrom '/media/a b'
sudo ./eject '/media/a b'
<works>
strace shows:
umount("/media/a b", 0) = 0
|
