| Summary: | einstall() improperly cheks for ${PORTAGE_DEBUG}. | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Peter Volkov (RETIRED) <pva> |
| Component: | [OLD] Unspecified | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 147007 | ||
| Attachments: | Proposed patch to fix the problem. | ||
Created attachment 98355 [details, diff]
Proposed patch to fix the problem.
This patch also fixed quotation of ${D}.
TIA
Thanks, your patch is in svn r4556 and r4557. This has been released in 2.1.2_pre2. |
Hello. In emerge it is clearly stated that PORTAGE_DEBUG variable can be either 0 or 1: if PORTAGE_DEBUG not in (0, 1): portage.writemsg("!!! Invalid value: PORTAGE_DEBUG='%i'\n" % \ PORTAGE_DEBUG, noiselevel=-1) portage.writemsg("!!! PORTAGE_DEBUG must be either 0 or 1\n", But einstall() currently checks for existance of this variable: if [ ! -z "${PORTAGE_DEBUG}" ]; then make -n prefix=${D}/usr \ This check is always true and result is that all packages that use einstall call make with -n option. This causes files to be NOT updated and that is the reason for some packages fall into loop. patch follows.