Bug 149494 – einstall() improperly cheks for ${PORTAGE_DEBUG}.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Volkov (RETIRED) 2006-09-29 00:47:36 UTC]

Hello.

In emerge it is clearly stated that PORTAGE_DEBUG variable can be either 0 or 1:

  if PORTAGE_DEBUG not in (0, 1):
    portage.writemsg("!!! Invalid value: PORTAGE_DEBUG='%i'\n" % \
  PORTAGE_DEBUG, noiselevel=-1)
    portage.writemsg("!!! PORTAGE_DEBUG must be either 0 or 1\n",

But einstall() currently checks for existance of this variable:

if [ ! -z "${PORTAGE_DEBUG}" ]; then
  make -n prefix=${D}/usr \

This check is always true and result is that all packages that use einstall call make with -n option. This causes files to be NOT updated and that is the reason for some packages fall into loop.

patch follows.

[Comment 1 Peter Volkov (RETIRED) 2006-09-29 00:49:11 UTC]

Created attachment 98355 [details, diff]
Proposed patch to fix the problem.

This patch also fixed quotation of ${D}.

TIA

[Comment 2 Zac Medico 2006-09-29 10:48:48 UTC]

Thanks, your patch is in svn r4556 and r4557.

[Comment 3 Zac Medico 2006-09-29 16:50:14 UTC]

This has been released in 2.1.2_pre2.