Summary: | media-sound/rubyripper (new ebuild) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ben de Groot (RETIRED) <yngwin> |
Component: | New packages | Assignee: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | sound |
Priority: | High | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
media-sound/rubyripper-0.2 ebuild
media-sound/rubyripper-0.2.ebuild |
Description
Ben de Groot (RETIRED)
2006-09-07 11:54:14 UTC
Created attachment 96308 [details]
media-sound/rubyripper-0.2 ebuild
This ebuild is what I use, based on kpex-media overlay's 0.1.1 version. Of course: it works for me.
Ben, the ebuild is mostly good, but if you can fix a couple of things it would be better: - the license "as-is" is misplaced, the site states RubyRipper is under GPL2; - pkg_postinst is indented with 4 spaces, rather than tabs; - the identical sed calls on two files can become a single sed line; the sed dependency can be removed, it's not needed for non-system packages; - the ${S} entries should be quoted as "${S}" for extra safety; - the mp3 useflag should be encode instead (as that's what lame is used, I know, it's an unfortunate name for an useflag :( ). A part this, the ebuild looks fine, and I'd look forward to add it to portage soon after testing it a bit. Created attachment 96645 [details]
media-sound/rubyripper-0.2.ebuild
Improved ebuild.
It doesn't make sense to use the encode useflag for mp3 encoding. As the transcode ebuild also uses the mp3 useflag for the lame dependancy, I vote for keeping it simple and straightforward.
I thought a bit about the problem of lame and encode, and you are right. It does not make sense to use the encode useflag in this sense. I think it's probably time to get rid of the lame<->encode link. The ebuild sounds good to enter portage, let me test it a bit more and I'll see to do that. There was still the SLOT missing, and I missed it too :) Anyway, now in portage :) Thanks for submitting the ebuild. Thanks, Diego, for commiting this to portage! |