Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 146738 - media-sound/rubyripper (new ebuild)
Summary: media-sound/rubyripper (new ebuild)
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Diego Elio Pettenò (RETIRED)
Keywords: EBUILD
Depends on:
Reported: 2006-09-07 11:54 UTC by Ben de Groot (RETIRED)
Modified: 2006-09-15 18:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

media-sound/rubyripper-0.2 ebuild (rubyripper-0.2-r1.ebuild,1.23 KB, text/plain)
2006-09-07 11:56 UTC, Ben de Groot (RETIRED)
media-sound/rubyripper-0.2.ebuild (rubyripper-0.2-r2.ebuild,1.14 KB, text/plain)
2006-09-10 19:32 UTC, Ben de Groot (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben de Groot (RETIRED) gentoo-dev 2006-09-07 11:54:14 UTC
From :
"Rubyripper is a digital audio extraction algorithm that uses cdparanoia or cdda2wav in a sophisticated way to make sure that a CD rip is done succesfully and accurately. It is very similiar to and inspired by EAC. Rubyripper is written in the ruby programming language."

This is an excellent little program that makes exact rips from audio CDs and optionally encodes them as flac, ogg vorbis and/or mp3. It has both commandline and gtk2 GUI versions. I think this would be a great addition to Gentoo. Please review and consider for inclusion.
Comment 1 Ben de Groot (RETIRED) gentoo-dev 2006-09-07 11:56:35 UTC
Created attachment 96308 [details]
media-sound/rubyripper-0.2 ebuild

This ebuild is what I use, based on kpex-media overlay's 0.1.1 version. Of course: it works for me.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-09-09 05:07:28 UTC
Ben, the ebuild is mostly good, but if you can fix a couple of things it would be better:

- the license "as-is" is misplaced, the site states RubyRipper is under GPL2;
- pkg_postinst is indented with 4 spaces, rather than tabs;
- the identical sed calls on two files can become a single sed line; the sed dependency can be removed, it's not needed for non-system packages;
- the ${S} entries should be quoted as "${S}" for extra safety;
- the mp3 useflag should be encode instead (as that's what lame is used, I know, it's an unfortunate name for an useflag :( ).

A part this, the ebuild looks fine, and I'd look forward to add it to portage soon after testing it a bit.
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2006-09-10 19:32:44 UTC
Created attachment 96645 [details]

Improved ebuild.

It doesn't make sense to use the encode useflag for mp3 encoding. As the transcode ebuild also uses the mp3 useflag for the lame dependancy, I vote for keeping it simple and straightforward.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-09-15 07:35:29 UTC
I thought a bit about the problem of lame and encode, and you are right. It does not make sense to use the encode useflag in this sense. I think it's probably time to get rid of the lame<->encode link.

The ebuild sounds good to enter portage, let me test it a bit more and I'll see to do that.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-09-15 12:21:44 UTC
There was still the SLOT missing, and I missed it too :)

Anyway, now in portage :) Thanks for submitting the ebuild.
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2006-09-15 18:28:47 UTC
Thanks, Diego, for commiting this to portage!