| Summary: | vmware-modules-1.0.0.13 does not compile with KBUILD_OUTPUT | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Georgi Georgiev <chutz+bugs.gentoo.org> |
| Component: | New packages | Assignee: | Gentoo VMWare Bug Squashers [disabled] <vmware+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | 2006.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 137422 | ||
| Attachments: | vmware-mod.eclass.kbuild-output.patch | ||
Created attachment 93479 [details, diff]
vmware-mod.eclass.kbuild-output.patch
This fixes the problem for the vmware-mod eclass. Tested for vmware-modules-1.0.0.13 only and there is a good chance that it doesn't work for the other module version. Please consider applying the patch even if only conditionally for vmmon and vmnet.
Hi Georgi,
Thanks for highlighting the problem. A simpler solution would be to add KBUILD_OUTPUT=${KV_OUT_DIR}, into the BUILD_TARGETS line which should have the same effect.
I've added this to the vmware testing overlay, so if you'd like to test it for me please use the ebuilds (and more specifically eclass) in there. If it all works, please let me know and I'll make the appropriate updates to the main tree... 5:)
You guys surely know what you're doing. Your solution is simpler and it surely works (just checked it). Feel free to bump $PORTAGE whenever you feel like it. Georgi, I'm not intending to bump the package, since it will fail to install for those who have KBUILD_OUTPUT set, and won't affect those who don't. However, I'll mention it on this bug when I add the changes into portage... 5:) This is now in the CVS, and should be with the mirrors in about an hour. Please re-open this bug if you still experience the problem... 5:) |
steps to reproduce: 1. set KBUILD_OUTPUT =/var/tmp/linux-build/$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)-$(MYEXT) in /usr/src/linux/Makefile 2. emerge vmware-modules * Actual results: >>> Compiling source in /var/tmp/portage/vmware-modules-1.0.0.13/work ... * Preparing vmmon module *** Your sources installation is broken: *** /usr/src/linux/include/.. does not contain .config file *** vmmon/vmnet build may fail, or built vmmon/vmnet may crash. *** Hit ENTER to continue, or ^C to stop build. * expected results... the ebuild proceeding As background, I'd like to mention that I had the modules and the application (vmware-workstation) split in my personal overlay. I have always had KBUILD_OUTPUT set and I have never had this problem. So, the solution I am offering below has been tested for at least vmware-workstaiton since 5.0.0.13124. Ah, I'll just attach the patch after posting the bug.