Summary: | new ebuild: net-mail/gmail-notify-1.6.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Grant <davidgrant> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | CC: | net-mail+disabled, satana.hell |
Priority: | High | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://gmail-notify.sourceforge.net | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
screenshot of it working
gmail-notify-1.6.1.ebuild |
Description
David Grant
2006-07-10 12:38:51 UTC
Please assign to maintainer-wanted@gentoo.org Draft here: http://www.rafb.net/paste/results/k3o9sO54.html for review at #gentoo-sunrise Created attachment 91390 [details]
screenshot of it working
This is now in the sunrise overlay. You can find it at: http://gentoo-sunrise.org/svn/reviewed/net-mail/gmail-notify/ Few things: - http://gmail-notify.sourceforge.net/ would be better for HOMEPAGE - >=dev-python/pygtk-2.0* and >=x11-libs/gtk+-2.4* should not have an asterisk - you should not be deleting files from S in src_install - look at make_wrapper() from eutils.eclass - where do you use bzip2 in the ebuild? I don't know why I was thinking bzip2 when it is a .tar.gz. Do I need to explicitly depend on gzip? make_wrapper is being used now I installed like this: doins *.py *.jpg *.png langs.xml pytrayicon.so notifier.conf.sample instead of deleted the readme and doing "doins *" fixed URL and removed asterisks Only problem left is this: QA Notice: pre-stripped files found: /var/tmp/portage/gmail-notify-1.6.1/image/usr/lib/python2.4/site-packages/gmail-notify/pytrayicon.so (In reply to comment #7) > Do I need to explicitly depend on gzip? no > Only problem left is this: > QA Notice: pre-stripped files found: Yes, that is a problem. Ubuntu has a patch to use gnome-python-extras instead. can you provide a link? Here is ubuntu's diff: http://archive.ubuntu.com/ubuntu/pool/universe/g/gmail-notify/gmail-notify_1.6.1-0ubuntu2.diff.gz I'm going to try first to get this in to upstream rather than have 2 distros using these patches... I've already been in touch with the developer today. Created attachment 93955 [details]
gmail-notify-1.6.1.ebuild
updated ebuild (add RESTRICT="strip")
This is going to require a patch because there is this: LANGSXML_PATH=sys.path[0]+"/langs.xml" in GmailConfig.py which fails when sys.path[0] is not the path where gmail-notifier is installed too. There is lot of crap like this in the code, which I notice the ubuntu fixes a lot of. Not sure if I'll get around to taking care of these issues since I don't use it right now (although I would like too). Ok, that is fixed now, I updated the ebuild sunrise. *** Bug 223571 has been marked as a duplicate of this bug. *** New version released: simply rename to 1.6.1.1. Adds more localizations. I found a bug in the 1.6.1 ebuild, where even though there's a patch that makes it compile against egg.TrayIcon, src_install still installs the now-unused pytrayicon.so and as such revdep-rebuild will continuously try and rebuild it to resolve missing dependencies. I'm fixing this in sunrise while I version-bump the ebuild to 1.6.1.1 |