Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 137958

Summary: avidemux 2.1_pre1 fails to compile with gcc 4.x
Product: Gentoo Linux Reporter: Matheus Izvekov <mizvekov>
Component: [OLD] GCC PortingAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED WONTFIX    
Severity: normal CC: dliana, gcc-porting, sfullenwider, therion, zypher
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 150175    
Bug Blocks: 117482, 158340    
Attachments: fix

Description Matheus Izvekov 2006-06-25 11:27:32 UTC
attached patch fixes this
Comment 1 Matheus Izvekov 2006-06-25 11:28:17 UTC
Created attachment 90127 [details, diff]
fix
Comment 2 Florian Engelhardt 2006-06-28 01:17:11 UTC
Same problem here with gcc 4.1 on an amd64.
The attached patch solved the problem here too.

Maybe we should report this patch to upstream
Comment 3 moesasji 2006-07-04 04:03:05 UTC
This fix is quite strange.
The majority of changes in the fix are moving functions outside class-scope. 
So an awfull lot of function-calls in the format xx::yy are renamed to yy. 
Bad practice if you ask me as it is likely to introduce difficult to find errors and those restrictions are there for a reason. What is the real "fix" is therefore extremely difficult to figure out. 

I've had no problems compiling avidemux 2.1 with gcc 4.x on ~x86. 
To know what is going on an emerge --info and error-message would be usefull.


Comment 4 Matheus Izvekov 2006-07-04 05:46:45 UTC
(In reply to comment #3)
> This fix is quite strange.
> The majority of changes in the fix are moving functions outside class-scope. 
> So an awfull lot of function-calls in the format xx::yy are renamed to yy. 
> Bad practice if you ask me as it is likely to introduce difficult to find
> errors and those restrictions are there for a reason. What is the real "fix" is
> therefore extremely difficult to figure out. 
> 
> I've had no problems compiling avidemux 2.1 with gcc 4.x on ~x86. 
> To know what is going on an emerge --info and error-message would be usefull.
> 

No its not strange at all, those are methods not functions, the xx: I removed is the object name the method belongs to. We have to remove it because newer gcc deprecates this.
Comment 5 moesasji 2006-07-04 07:23:13 UTC
> No its not strange at all, those are methods not functions, the xx: I removed
> is the object name the method belongs to. We have to remove it because newer
> gcc deprecates this.
> 
Good, I did not know that this has been deprecated with GCC 4.1. I stand corrected on misusing functions where I should have said methods. 

I however still don't understand why I don't have the same problems compiling on ~x86. 
Comment 6 Matheus Izvekov 2006-07-04 12:35:19 UTC
I sent this patch upstream, the author said most of those are already fixed there, but gentoo is too much lagged behind.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-09-17 01:37:25 UTC
*** Bug 147833 has been marked as a duplicate of this bug. ***
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2006-11-18 06:21:24 UTC
*** Bug 154845 has been marked as a duplicate of this bug. ***
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-01-06 16:27:30 UTC
*** Bug 160491 has been marked as a duplicate of this bug. ***
Comment 10 Steve Dibb (RETIRED) gentoo-dev 2007-02-03 13:23:49 UTC
removed from tree, file a new bug if an issue with 2.3.0