Bug 133591

Summary:	portage_file.py clean-ups
Product:	Portage Development	Reporter:	Albert Hopkins (RETIRED) <marduk>
Component:	Core	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	trivial	Keywords:	InVCS
Priority:	High
Version:	2.1
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	133068, 136244
Attachments:	Said patch

Description Albert Hopkins (RETIRED) gentoo-dev

2006-05-17 05:57:00 UTC

Here are some various clean-ups to portage_file.py.  It eliminates 7 errors and 5 warnings (as reported by pylint).

More specifically, I don't think the makedirs() function is used anywhere (though I have not checked) as it contained so many errors that it could not be used.  It may be a candidate for removal from this module.

Patch follows.

Comment 1 Albert Hopkins (RETIRED) gentoo-dev

2006-05-17 05:57:37 UTC

Created attachment 86920 [details, diff]
Said patch

Comment 2 Alec Warner (RETIRED) archtester

2006-05-25 20:09:32 UTC

the systemExit except can get nuked, but I'll tag this for 2.1.1/2.2 due to the code freeze on 2.1.0

Comment 3 Zac Medico gentoo-dev

2006-07-15 12:10:53 UTC

I've removed the whole module in svn r3892.

Comment 4 Zac Medico gentoo-dev

2006-07-16 18:28:11 UTC

This has been released in 2.1.1_pre3-r1.