Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 133591 - portage_file.py clean-ups
Summary: portage_file.py clean-ups
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 133068 136244
  Show dependency tree
 
Reported: 2006-05-17 05:57 UTC by Albert Hopkins (RETIRED)
Modified: 2006-07-16 18:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Said patch (portage_file.py.patch,2.38 KB, patch)
2006-05-17 05:57 UTC, Albert Hopkins (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Hopkins (RETIRED) gentoo-dev 2006-05-17 05:57:00 UTC 
Here are some various clean-ups to portage_file.py.  It eliminates 7 errors and 5 warnings (as reported by pylint).

More specifically, I don't think the makedirs() function is used anywhere (though I have not checked) as it contained so many errors that it could not be used.  It may be a candidate for removal from this module.

Patch follows.
Comment 1 Albert Hopkins (RETIRED) gentoo-dev 2006-05-17 05:57:37 UTC 
Created attachment 86920 [details, diff]
Said patch
Comment 2 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-05-25 20:09:32 UTC 
the systemExit except can get nuked, but I'll tag this for 2.1.1/2.2 due to the code freeze on 2.1.0
Comment 3 Zac Medico gentoo-dev 2006-07-15 12:10:53 UTC 
I've removed the whole module in svn r3892.
Comment 4 Zac Medico gentoo-dev 2006-07-16 18:28:11 UTC 
This has been released in 2.1.1_pre3-r1.