Summary: | New QA warning - detect already stripped binaries in prepstrip | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Robin Johnson <robbat2> |
Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | Inclusion, InVCS |
Priority: | High | ||
Version: | 2.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 115839 | ||
Attachments: |
prepstrip-log-stripped.patch
prepstrip-log-stripped-take2.patch |
Description
Robin Johnson
2006-05-15 14:56:37 UTC
Created attachment 86824 [details, diff]
prepstrip-log-stripped.patch
I like the basic idea here a lot, but sadly we have been getting people complaining about the speed of the binary checks. How would you feel about letting this be controlled via a FEATURE= ? Maybe something like.. if ! hasq nostripcheck ${FEATURES}; then run_the_first_hunk fi Which would allow it to be enabled per default and give those that really don't care a way to bypass it. hmm, ok, how about having this, and similar 'extra' QA stuff behind a feature called 'wellbehavedqa', instead of seperate flags for each things over time? the feature should default to on, and for folk that file bugs without it, they should come back with it turned on. Please disregard comment #2 After talking with others on the portage team it was decided that no extra feature should be introduced for this. It should simply be on/forced by default exactly like your patch already does. Now. Would you mind updating your patch for current svn. It currently fails to apply. Created attachment 87831 [details, diff]
prepstrip-log-stripped-take2.patch
New version as requested by solar, based on SVN head.
I changed it to match similar coding in prepstrip now with the vecho usage.
Thanks! This is in svn r3440. This has been released in 2.1_rc3-r2. |