Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 133420 - New QA warning - detect already stripped binaries in prepstrip
Summary: New QA warning - detect already stripped binaries in prepstrip
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: Inclusion, InVCS
Depends on:
Blocks: 115839
  Show dependency tree
 
Reported: 2006-05-15 14:56 UTC by Robin Johnson
Modified: 2006-05-29 23:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
prepstrip-log-stripped.patch (prepstrip-log-stripped.patch,1.00 KB, patch)
2006-05-15 14:57 UTC, Robin Johnson
Details | Diff
prepstrip-log-stripped-take2.patch (prepstrip-log-stripped-take2.patch,979 bytes, patch)
2006-05-29 15:43 UTC, Robin Johnson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-15 14:56:37 UTC
I've created a patch for prepstrip that detects if a binary was already stripped, and issues a QA notice.

This allows tracking of binaries that are already stripped, and for which splitdebug will be useless.

Additionally, this modifies the existing stripping loop to only strip files that need stripping, thus avoiding some UPX executables that might get broken.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-15 14:57:17 UTC
Created attachment 86824 [details, diff]
prepstrip-log-stripped.patch
Comment 2 solar (RETIRED) gentoo-dev 2006-05-26 16:35:46 UTC
I like the basic idea here a lot, but sadly we have been getting people
complaining about the speed of the binary checks. How would you feel
about letting this be controlled via a FEATURE= ? Maybe something like..

if ! hasq nostripcheck ${FEATURES}; then
 run_the_first_hunk
fi

Which would allow it to be enabled per default and give those that 
really don't care a way to bypass it.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-26 16:55:23 UTC
hmm, ok, how about having this, and similar 'extra' QA stuff behind a feature called 'wellbehavedqa', instead of seperate flags for each things over time?

the feature should default to on, and for folk that file bugs without it, they should come back with it turned on.
Comment 4 solar (RETIRED) gentoo-dev 2006-05-27 04:58:49 UTC
Please disregard comment #2 After talking with others on the portage 
team it was decided that no extra feature should be introduced for
this. It should simply be on/forced by default exactly like your patch
already does. Now. Would you mind updating your patch for current svn.
It currently fails to apply.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-29 15:43:23 UTC
Created attachment 87831 [details, diff]
prepstrip-log-stripped-take2.patch

New version as requested by solar, based on SVN head.
I changed it to match similar coding in prepstrip now with the vecho usage.
Comment 6 Zac Medico gentoo-dev 2006-05-29 20:53:28 UTC
Thanks! This is in svn r3440.
Comment 7 Zac Medico gentoo-dev 2006-05-29 23:23:14 UTC
This has been released in 2.1_rc3-r2.