Bug 129230

Summary:	gnome-system-tools-2.14.0 patch to build with --as-needed
Product:	Gentoo Linux	Reporter:	Mike Auty (RETIRED) <ikelos>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tom.gl
Priority:	High
Version:	2006.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	129413
Attachments:	gnome-system-tools-2.14.0-as-needed.patch

Description Mike Auty (RETIRED) gentoo-dev

2006-04-08 06:26:15 UTC

gnome-system-tools-2.14.0 fails to build with LDFLAGS="-Wl,--as-needed" because it puts the local libsetuptool.a after the main GST_LIBS, which then get stripped out by --as-needed.  The patch reorders them, however, it's done in configure.in and I'm not sure if this is the best place to do it, so it might be best to ask flameeyes to check over it if he's got time.

Patch to follow.

Comment 1 Mike Auty (RETIRED) gentoo-dev

2006-04-08 06:27:10 UTC

Created attachment 84202 [details, diff]
gnome-system-tools-2.14.0-as-needed.patch

Comment 2 Josh Nichols (RETIRED) gentoo-dev

2006-04-10 22:05:41 UTC

The patch works fine over here.

Comment 3 TGL 2006-05-07 14:34:29 UTC

Works for me too (binutils-2.16.92, LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--sort-common").

Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev

2006-05-07 20:27:32 UTC

Fixed in CVS.  Thanks for the patch.