Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 129230 - gnome-system-tools-2.14.0 patch to build with --as-needed
Summary: gnome-system-tools-2.14.0 patch to build with --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2006-04-08 06:26 UTC by Mike Auty (RETIRED)
Modified: 2006-05-07 20:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
gnome-system-tools-2.14.0-as-needed.patch (gnome-system-tools-2.14.0-as-needed.patch,651 bytes, patch)
2006-04-08 06:27 UTC, Mike Auty (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2006-04-08 06:26:15 UTC 
gnome-system-tools-2.14.0 fails to build with LDFLAGS="-Wl,--as-needed" because it puts the local libsetuptool.a after the main GST_LIBS, which then get stripped out by --as-needed.  The patch reorders them, however, it's done in configure.in and I'm not sure if this is the best place to do it, so it might be best to ask flameeyes to check over it if he's got time.

Patch to follow.
Comment 1 Mike Auty (RETIRED) gentoo-dev 2006-04-08 06:27:10 UTC 
Created attachment 84202 [details, diff]
gnome-system-tools-2.14.0-as-needed.patch
Comment 2 Josh Nichols (RETIRED) gentoo-dev 2006-04-10 22:05:41 UTC 
The patch works fine over here.
Comment 3 TGL 2006-05-07 14:34:29 UTC 
Works for me too (binutils-2.16.92, LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--sort-common").
Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev 2006-05-07 20:27:32 UTC 
Fixed in CVS.  Thanks for the patch.