Bug 128937

Summary:	dev-libs/libusb: don't redefine usb_hid_descriptor
Product:	Gentoo/Alt	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	Other	Assignee:	Alastair Tse (RETIRED) <liquidx>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bsd+disabled
Priority:	High
Version:	unspecified
Hardware:	All
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	libusb-0.1.12-fbsd-hid.patch Ebuild patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2006-04-05 10:37:22 UTC

The attached patch (that I've submitted upstream too) checks for usb_hid_descriptor struct presence before defining it, so that it doesn't override the system's definition.
This is needed for SDL to detect usb support (and thus joysticks) correctly.

The attached patch is over libusb-0.1.12, should work with 0.1.11 too, but as it would require a version bump, it would help if it was added with the version bump.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-04-05 10:45:02 UTC

Created attachment 83994 [details, diff]
libusb-0.1.12-fbsd-hid.patch

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-04-05 13:00:58 UTC

Created attachment 84016 [details, diff]
Ebuild patch

This patch to the ebuild adds a bit of verbosity to the || die during src_install, as I was a bit surprised when it failed, and adds a missing dependency over docbook-dsssl-stylesheets without which I can't actually build the documentation at all.

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-04-18 11:40:07 UTC

This would really be needed soon.

Alastair, if you can't commit this in about 10 days, I'll go on and handle it in the mean time (taking the pieces if something breaks of course).

Comment 4 Alastair Tse (RETIRED) gentoo-dev

2006-04-24 14:29:41 UTC

in 0.1.12. thanks for the patch.