Summary: | media-sound/cdparanoia: Add Red Hat patches for SG_IO instead of cooked ioctl | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sebastian <sebastian_ml> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | 4nykey, chainsaw, chutzpah, gentoo.bugzilla, magnade, Sander.Sweers |
Priority: | High | Keywords: | InVCS |
Version: | 2005.1 | ||
Hardware: | x86 | ||
OS: | Linux | ||
URL: | http://people.redhat.com/pjones/cdparanoia/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Suggested ebuild
Patches from Red Hat |
Description
Sebastian
2006-01-07 08:47:43 UTC
Created attachment 76454 [details]
Suggested ebuild
Created attachment 76455 [details]
Patches from Red Hat
*** Bug 100601 has been marked as a duplicate of this bug. *** i tried these patchs out on an athlon64 box and have had no issues with them they have made it so i could rip a couple tracks that before had lots of pops of static, now sound crystal clear (In reply to comment #4) > i tried these patchs out on an athlon64 box and have had no issues with > them they have made it so i could rip a couple tracks that before > had lots of pops of static, now sound crystal clear > Thanks for your input, I appreciate it. Anyone else? Sebastian This gived a huge speedup in ripping :) Figures below but please note that I only applied the sg_io patch from RedHat not the others. Without SG_IO: real 18m23.228s user 0m19.766s sys 0m18.689s With SG_IO: real 5m14.834s user 0m11.736s sys 0m4.508s I'll try the dma patch also to see if this gived any speed increase. Nope, the dma patch did not do anything in the speed department. If i could vote, i would vote to get at least the sg_io patch included. I tested before and after patch. No error messages on the unpatched version, but a slight increase in speed after patch. 459 megabyte CD over five tracks. Start/finish times are as follows. Before patch: Sun Jan 22 14:01:40 GMT 2006 Sun Jan 22 14:04:18 GMT 2006 After patch: Sun Jan 22 14:26:42 GMT 2006 Sun Jan 22 14:28:44 GMT 2006 Has anyone tested this on a 2.4 kernel? (In reply to comment #9) > Has anyone tested this on a 2.4 kernel? > Not me, sorry, don't have such a thing around anymore. New revision of cdparanoia that applies these patches with a 2.6 kernel committed. While the sg_io has a few nice effects(such as working properly on my audio caching drive), the speed command doesn't have the desired effect (Ripping seems slower, but the drive speed/noise stays the same). Anyone experience the same? Didnt work
command:ACCEPT_KEYWORDS="~x86" emerge cdparanoia
kernel:2.6.10-gentoo-r6
I tried to emerge this patch but got failed errors. Here is my output:
* Determining the location of the kernel source code
* Found kernel source directory:
* /usr/src/linux
* Found sources for kernel version:
* 2.6.10-gentoo-r6
>>> Unpacking source...
>>> Unpacking cdparanoia-III-alpha9.8.src.tgz to /var/tmp/portage/cdparanoia-3.9.8-r3/work
>>> Unpacking cdparanoia-3.9.8-SG_IO-patches.tar.gz to /var/tmp/portage/cdparanoia-3.9.8-r3/work
* Applying cdparanoia-3.9.8-include-cdda_interface_h.patch ... [ ok ]
* Applying cdparanoia-3.9.8-toc.patch ... [ ok ]
* Applying cdparanoia-3.9.8-identify_crash.patch ... [ ok ]
* Applying 3.9.8-gcc34.patch ... [ ok ]
* Applying cdparanoia-3.9.8-use-destdir.patch ... [ ok ]
* Applying cdparanoia-3.9.8-respectflags.patch ...
* Failed Patch: cdparanoia-3.9.8-respectflags.patch !
* ( /usr/portage/media-sound/cdparanoia/files/cdparanoia-3.9.8-respectflags.patch )
*
* Include in your bugreport the contents of:
*
* /var/tmp/portage/cdparanoia-3.9.8-r3/temp/cdparanoia-3.9.8-respectflags.patch-14222.out
Now for the .out file:
***** cdparanoia-3.9.8-respectflags.patch *****
===============================================
PATCH COMMAND: patch -p0 -g0 -E --no-backup-if-mismatch < /usr/portage/media-sound/cdparanoia/files/cdparanoia-3.9.8-respectflags.patch
===============================================
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/interface/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/interface/Makefile.in
|+++ cdparanoia-III-alpha9.8/interface/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 18
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/paranoia/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/paranoia/Makefile.in
|+++ cdparanoia-III-alpha9.8/paranoia/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
===============================================
PATCH COMMAND: patch -p1 -g0 -E --no-backup-if-mismatch < /usr/portage/media-sound/cdparanoia/files/cdparanoia-3.9.8-respectflags.patch
===============================================
patching file interface/Makefile.in
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.in.rej
patching file Makefile.in
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.in.rej
===============================================
PATCH COMMAND: patch -p3 -g0 -E --no-backup-if-mismatch < /usr/portage/media-sound/cdparanoia/files/cdpar
anoia-3.9.8-respectflags.patch
===============================================
missing header for unified diff at line 5 of patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/interface/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/interface/Makefile.in
|+++ cdparanoia-III-alpha9.8/interface/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 18 of patch
can't find file to patch at input line 18
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/paranoia/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/paranoia/Makefile.in
|+++ cdparanoia-III-alpha9.8/paranoia/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
===============================================
PATCH COMMAND: patch -p4 -g0 -E --no-backup-if-mismatch < /usr/portage/media-sound/cdparanoia/files/cdparanoia-3.9.8-respectflags.patch
===============================================
missing header for unified diff at line 5 of patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/interface/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/interface/Makefile.in
|+++ cdparanoia-III-alpha9.8/interface/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 18 of patch
can't find file to patch at input line 18
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: cdparanoia-III-alpha9.8/paranoia/Makefile.in
|===================================================================
|--- cdparanoia-III-alpha9.8.orig/paranoia/Makefile.in
|+++ cdparanoia-III-alpha9.8/paranoia/Makefile.in
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
As there's a routine in the ebuild checking for the kernel version before considering to apply the Red Hat patches I think the routine is faulty for kernels <2.6.15. |