| Summary: | TEXTREL in media-plugins/xmms-mpg123-1.2.10-r1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Lares Moreau <lares.moreau> |
| Component: | Hardened | Assignee: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | hardened, pageexec, sound, SpOeK, vapier |
| Priority: | High | Keywords: | PMASKED |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 152472 | ||
| Bug Blocks: | |||
| Attachments: |
xmms-mpg123-1.2.10-PIC-fix.patch
solar patch ¿fixed? solar patch ¿fixed? |
||
|
Description
Lares Moreau
2005-12-14 11:05:42 UTC
Created attachment 74751 [details, diff]
xmms-mpg123-1.2.10-PIC-fix.patch
This should fix the problem. (Orig patch from PaX Team?)
*** Bug 105716 has been marked as a duplicate of this bug. *** Created attachment 82044 [details, diff]
solar patch ¿fixed?
Created attachment 82044 [details, diff] solar patch ¿fixed? I've tried solar's patch but it makes xmms seg fault when connecting to a mp3 stream (http://streams.frequence3.net/mp3-192.m3u). I've reviewed the patch and fixed some lines (well, I think that my changes are fixes, so please, try to be magnanimous :D) . Now it works perfectly for me. The changes are related to dct36_3dnow.s and dct64_3dnow.s. The rest of the patch is solar's original. Created attachment 82049 [details, diff]
solar patch ¿fixed?
Created attachment 82049 [details, diff]
solar patch ¿fixed?
Oops, my previous attachment was solar's patch. Now it's the correct file.
(In reply to comment #4) I stated in comment #1 of this bug that the patch does not stem from me. Adding the PaX Team to CC: list Well, I knew that the patch was not stem from you. "solar's patch" is shorter than "xmms-mpg123-1.2.10-PIC-fix.patch" and as name is not completely wrong/inexact (you uploaded it). I'm sorry! thanks for the fix, i checked it out quickly (interdiff) and it looks fine to me, makes me wonder just what i was thinking back then ;P. solar, can this go into portage then? Sound herd. OK to merge this in ~arch? This fixes a long standing policy about shared objects and pic handling. A question (this is not the best place to ask, I know it), the ebuild xmms-mpg123-1.2.10-r1.ebuild has the following lines:
if use x86 && ! has_pic && { use mmx || use 3dnow; }; then
myconf="${myconf} --enable-simd"
else
myconf="${myconf} --disable-simd"
fi
If the shared libraries must be always pic and the assembler files now are pic-aware, is the has_pic check necessary?
the ebuild code can drop the has_pic logic now xmms and all plugins are now package.masked and will be removed from the tree in one month. @Flameeyes: you forgot to p.mask this one; WONTFIX once done. ;) Ready to mask (wait till I commit). |
