Summary: | catalyst appends kernel args multiple times | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | georg.lippold |
Component: | [OLD] Development | Assignee: | Gentoo Catalyst Developers <catalyst> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
fix for kernel args
fix for kernel args isolinux.cfg created by catalyst livecd-stage2.spec used to generate isolinux.cfg fix for kernel args |
Description
georg.lippold
2005-10-07 06:52:31 UTC
Created attachment 70078 [details, diff]
fix for kernel args
Created attachment 70080 [details, diff]
fix for kernel args
first diff was in the wrong direction
I don't see what you're trying to fix. Catalyst only appends the arguments *once* per kernel. This has been verified by me over several *hundred* catalyst runs, along with every other Release Engineering member, as they've done their countless release builds using this tool, too. Created attachment 70092 [details]
isolinux.cfg created by catalyst
Created attachment 70093 [details]
livecd-stage2.spec used to generate isolinux.cfg
Please check this out... Why are you adding options that are already a default in your livecd-stage2? You're also using --gensplash-res, which is causing even more of the issues, as it completely overrides the -nofb option's capabilities. At any rate, it is a configuration issue, and not an issue with catalyst. I'm really not sure that we should be spending time trying to sanitize the user's input. It's my personal feeling that the user knows best. I'll think about including the sanitizing code. Created attachment 70109 [details, diff]
fix for kernel args
added = at the end of options, otherwise grep would get errors with looptype=
and loop=
rocket: what do you think about this for catalyst 2.0? I tend to think that if the user is going to put things that are busted in their bootargs, that we shouldn't be trying to sanitize it... We're not in the business of telling the user what to do... they're free to break their boot all on their own... :P |