Bug 105716

Summary:	media-plugins/xmms-mpg123 has text relocations
Product:	Gentoo Linux	Reporter:	SpOeK
Component:	[OLD] Library	Assignee:	Luis Medinas (RETIRED) <metalgod>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	sound
Priority:	High
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	The patch for the assembler code. The new ebuild that uses the patch The patch for the assembler code, uncompressed. The updated ebuild This ebuild patches the assembler files to make the built library fully pic.

Description SpOeK 2005-09-12 12:03:57 UTC

This library (libmpg123.so) has text relocations. The problem is in the
assembler files included, which are not pic-aware. I've created a patch that
fixes this issue using this documentation:
http://lists.virus.org/grsec-0501/msg00003.html
http://linux4u.jinr.ru/usoft/WWW/www_debian.org/Documentation/elf/node23.html#SECTION00062000000000000000

The new libmpg123.so works fine in my system and now is fully pic.


Reproducible: Always
Steps to Reproduce:
1. emerge xmms-mpg123
2.
3.

Actual Results:  
The library libmpg123.so is not fully pic.

Expected Results:  
It should generate a pic library.

Portage 2.0.51.22-r2 (default-linux/x86/2005.0, gcc-3.3.6, glibc-2.3.5-r1,
2.6.12-gentoo-r10 i686)
=================================================================
System uname: 2.6.12-gentoo-r10 i686 AMD Athlon(tm) XP 1900+
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5-r2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=athlon-xp -mcpu=athlon-xp -O2 -pipe -fomit-frame-pointer -ffast-math"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -mcpu=athlon-xp -O3 -pipe -fomit-frame-pointer
-ffast-math"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig candy distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://linuv.uv.es/mirror/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowext S3TC X aac acpi alsa avi bash-completion berkdb
bitmap-fonts bzip2 bzlib cdr crypt curl dga dio divx4linux dvd emboss esd
font-server ftp ggi gif gpm gstreamer gtk gtk2 imagemagick imlib jabber jpeg
libwww lzo mad matroska mikmod mmx mmxext motif mozilla mp3 mpeg msn ncurses nls
nptl nptlonly ogg oggvorbis opengl oss pam pdflib perl pic pie png posix python
qt quicktime readline rtc samba sdl slang sockets softmmu speex sse ssl svga
symlink sysvipc szip tcpd tetex theora tiff truetype truetype-fonts type1-fonts
userlocales videos vorbis win32codecs wmf xml2 xmms xv xvid zlib userland_GNU
kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS

Comment 1 SpOeK 2005-09-12 12:05:23 UTC

Created attachment 68275 [details, diff]
The patch for the assembler code.

Comment 2 SpOeK 2005-09-12 12:09:12 UTC

Created attachment 68276 [details]
The new ebuild that uses the patch

I've removed the "has_pic" check because now the library is pic. No matter if
you enable or disable SIMD.

Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev

2005-09-13 02:05:22 UTC

could you do me a favor and post that patch in plain text rather than compressed?

Comment 4 SpOeK 2005-09-13 03:57:31 UTC

Created attachment 68342 [details, diff]
The patch for the assembler code, uncompressed.

Comment 5 SpOeK 2005-09-13 03:58:26 UTC

Created attachment 68343 [details]
The updated ebuild

Comment 6 Jeremy Huddleston (RETIRED) gentoo-dev

2005-10-05 19:09:50 UTC

bumping to herd as i nolonger maintain xmms

Comment 7 SpOeK 2005-10-16 05:19:28 UTC

Created attachment 70786 [details]
This ebuild patches the assembler files to make the built library fully pic.

I've updated the ebuild removing the line:
    inherit flag-o-matic
because of the resolution of this bug:
http://bugs.gentoo.org/show_bug.cgi?id=87232

Comment 8 Jakub Moc (RETIRED) gentoo-dev

2006-03-07 00:10:13 UTC


*** This bug has been marked as a duplicate of 115565 ***