| Summary: | new version of Midnight Commander 4.6.1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Cramer <portage> |
| Component: | Current packages | Assignee: | Heinrich Wendel (RETIRED) <lanius> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | borovoy.anton, crook, eddymul, emdej, galtgendo, gurligebis, hanno, martin.nowack, morpheusz, pdenapo, polynomial-c, rockoo, shark, SpOeK, spreetec, stefan, vdmitri, wladyx, yamadharma |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 122768 | ||
| Attachments: |
Midnight Commander 4.6.1 test ebuild
app-misc/mc-4.6.1.ebuild mc-4.6.1 ebuild with patches app-misc/mc-4.6.1.ebuild files/mc-4.6.1-utf8.patch.bz2 files/mc-4.6.1-ebuild-syntax.patch files/mc-4.6.1-7zip.patch app-misc/mc-4.6.1.ebuild files/mc-4.6.1-patches.tar.bz2 files/mc.ini files/mcserv.rc files/mcserv.pamd files/mc-dnlike.color files/mc-dark.color files/mc-4.6.1-utf8.patch.bz2 reverting the change |
||
|
Description
Michael Cramer
2005-08-06 02:37:07 UTC
*** Bug 101596 has been marked as a duplicate of this bug. *** *** Bug 106362 has been marked as a duplicate of this bug. *** I've renamed the mc-4.6.0-r14.ebuild and removed the various patches for the 4.6.0 from the ebuild. Worked without problem on ~x86,but i didn't use the following USE flags:"samba slang unicode" so i'm not sure that it will work for anyone. Created attachment 68967 [details]
Midnight Commander 4.6.1 test ebuild
Hi, i can't compile mc 4.6.0-r14 together with 2.6.13-gentoo and samba support. I downloaded mc 4.6.1 manually, start it with the configure parameter, generated before by 4.6.0-r14 ebuild and 4.6.1 compiles cleanly. Please update to 4.6.1. Used configure: ./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --with-vfs --with-gnu-ld --with-ext2undel --with-edit --enable-charset --with-screen=slang --without-gpm-mouse --with-included-gettext --with-x --with-samba --with-configdir=/etc/samba --with-codepagedir=/var/lib/samba/codepages --with-privatedir=/etc/samba/private --build=i686-pc-linux-gnu System info: Portage 2.0.52-r1 (default-linux/x86/2005.0, gcc-3.4.4, glibc-2.3.5-r1, 2.6.13-gentoo i686) ================================================================= System uname: 2.6.13-gentoo i686 AMD Sempron(tm) 2200+ Gentoo Base System version 1.12.0_pre8 dev-lang/python: 2.3.5, 2.4.1-r1 sys-apps/sandbox: 1.2.13 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6 sys-devel/binutils: 2.16.1 sys-devel/libtool: 1.5.20 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=athlon -Os -pipe -m3dnow -msse -mfpmath=sse -mmmx -fomit-frame-pointer -mno-tls-direct-seg-refs" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d" CXXFLAGS="-O2 -march=athlon -Os -pipe -m3dnow -msse -mfpmath=sse -mmmx -fomit-frame-pointer -mno-tls-direct-seg-refs" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig distlocks sandbox sfperms strict" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo" LINGUAS="de" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local-portage" SYNC="rsync://gentoo.prodigy7.priv/portage" USE="x86 3dnow 3dnowext X X11 a52 alsa apache2 apm arts avi berkdb bitmap-fonts crypt curl divx divx4linux dts dvb dvb-eit dvd dvdread eds eit emboss encode fam ffmpeg flac foomaticdb fortran freetype gd gd-external gdbm gif gnutls gstreamer gtk gtk2 httpd imlib ithreads jpeg kde libclamav libg++ libwww lirc mad mcal mikmod mmx mmxext motif mp3 mpeg mplayer mysql mythtv ncurses network nls nptl nptlonly ogg oggvorbis opengl oss pam pdflib perl png pthreads python qt quotas readline rtc samba sdl sftplogging slang spell sse ssl stream svga tcltk tcpd tetex theora tiff transcode truetype truetype-fonts type1-fonts userlocales v4l v4l2 vorbis xine xinerama xml xml2 xorg xv xvid zlib fcdsl_cards_fcdsl linguas_de userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS I forgot - the error message: i686-pc-linux-gnu-gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O2 -march=athlon -Os -pipe -m3dnow -msse -mfpmath=sse -mmmx -fomit-frame-pointer -mno-tls-direct-seg-refs -I/usr/include/gssapi -Wall -o mc achown.o background.o boxes.o chmod.o chown.o cmd.o color.o command.o complete.o cons.handler.o dialog.o dir.o dlg.o ext.o file.o filegui.o filenot.o fileopctx.o find.o findme.o fsusage.o help.o hotlist.o info.o key.o keyxdef.o layout.o learn.o listmode.o main.o menu.o mountlist.o mouse.o option.o panelize.o popt.o poptconfig.o popthelp.o poptparse.o profile.o regex.o rxvt.o screen.o setup.o slint.o subshell.o terms.o text.o textconf.o tree.o treestore.o user.o util.o utilunix.o view.o widget.o win.o wtools.o charsets.o selcodepage.o ../edit/libedit.a ../vfs/libvfs-mc.a ../intl/libintl.a -lglib-2.0 -lSM -lICE -lX11 -lslang -lsmbclient i686-pc-linux-gnu-gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O2 -march=athlon -Os -pipe -m3dnow -msse -mfpmath=sse -mmmx -fomit-frame-pointer -mno-tls-direct-seg-refs -I/usr/include/gssapi -Wall -o mcmfmt mfmt.o i686-pc-linux-gnu-gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O2 -march=athlon -Os -pipe -m3dnow -msse -mfpmath=sse -mmmx -fomit-frame-pointer -mno-tls-direct-seg-refs -I/usr/include/gssapi -Wall -o man2hlp man2hlp.o -lglib-2.0 ../vfs/libvfs-mc.a(smbfs.o): In function `smbfs_get_path': smbfs.c:(.text+0x1a19): undefined reference to `write_socket' collect2: ld returned 1 exit status make[2]: *** [mc] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/var/tmp/portage/mc-4.6.0-r14/work/mc-4.6.0/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/mc-4.6.0-r14/work/mc-4.6.0' make: *** [all] Error 2 *** Bug 108970 has been marked as a duplicate of this bug. *** *** Bug 109254 has been marked as a duplicate of this bug. *** Attaching another ebuild. Works well for me, but only without unicode use-flag Created attachment 71538 [details]
app-misc/mc-4.6.1.ebuild
I tried the 2005-10-26 ebuild. Got this error: /bin/install -c -m 644 'xml.syntax' '/var/tmp/portage/mc-4.6.1/image//usr/share/mc/syntax/xml.syntax' make[2]: Leaving directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1/syntax' make[1]: Leaving directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1/syntax' make[1]: Entering directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1' make[2]: Entering directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1' make[2]: Nothing to be done for `install-exec-am'. make[2]: Nothing to be done for `install-data-am'. make[2]: Leaving directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1' make[1]: Leaving directory `/var/tmp/portage/mc-4.6.1/work/mc-4.6.1' * Cannot find $EPATCH_SOURCE! Value for $EPATCH_SOURCE is: * * /usr/portage/app-misc/mc/files/mc-4.6.1-ebuild-syntax.patch * ( mc-4.6.1-ebuild-syntax.patch ) !!! ERROR: app-misc/mc-4.6.1 failed. !!! Function epatch, Line 220, Exitcode 0 !!! Cannot find $EPATCH_SOURCE! !!! If you need support, post the topmost build error, NOT this status message. emerge --info Portage 2.0.53_rc7 (default-linux/x86/2005.0, gcc-3.3.3, glibc-2.3.5-r3, 2.6.14-rc3 i686) ================================================================= System uname: 2.6.14-rc3 i686 AMD Athlon(TM)Processor Gentoo Base System version 1.12.0_pre9 dev-lang/python: 2.2.3-r5, 2.3.4, 2.4.2 sys-apps/sandbox: 1.2.13 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.16.1 sys-devel/libtool: 1.5.20-r1 virtual/os-headers: 2.4.19-r1, 2.6.11-r2 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/texmf/web2c /etc/env.d" CXXFLAGS="-O3 -march=athlon-xp -pipe -fomit-frame-pointer" DISTDIR="/distfiles" FEATURES="autoconfig distlocks sandbox sfperms strict" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo" MAKEOPTS="-j2" PKGDIR="/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="x86 3dnow X Xaw3d aac acl acpi alsa apm arts audiofile avi bash-completion berkdb bitmap-fonts bonobo bzip2 cdparanoia cdr crypt cups curl dbase dga directfb dri dvd dvdr dvdread eds emacs emboss encode esd evo exif expat fam fastcgi fbcon ffmpeg flac flash foomaticdb fortran ftp gb gd gdbm ggi gif gimpprint glut gnome gnutls gphoto2 gpm gstreamer gtk gtk2 gtkhtml guile gutenprint hal idn ieee1394 imagemagick imagemagik imlib ipv6 java javascript jikes jpeg junit kerberos lcms ldap libg++ libgda libwww lm_sensors mad mga mikmod mime ming mmx mng motif mozilla mp3 mpeg mpi msn mysql mysqli ncurses nls nptl nsplugin odbc ogg oggvorbis openal opengl osc oss pam pcre pda pdflib perl php png posix ppds python qt quicktime readline samba sane sasl scanner sdl slang slp snmp sockets socks5 source spell spl sse ssl svg svga sysvipc tcltk tcpd tetex threads tiff tokenizer truetype truetype-fonts type1-fonts udev unicode usb videos vorbis win32codecs wmf wxwindows xinerama xml xml2 xmms xosd xpm xsane xv xvid zeo zlib userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS (In reply to comment #11) [...] > * Cannot find $EPATCH_SOURCE! Value for $EPATCH_SOURCE is: > * > * /usr/portage/app-misc/mc/files/mc-4.6.1-ebuild-syntax.patch > * ( mc-4.6.1-ebuild-syntax.patch ) > > > !!! ERROR: app-misc/mc-4.6.1 failed. > !!! Function epatch, Line 220, Exitcode 0 > !!! Cannot find $EPATCH_SOURCE! > !!! If you need support, post the topmost build error, NOT this status >message. [...] I think this happens because there's no mc-4.6.1-ebuild-syntax.patch file in the portage's dir. you should rename the file "mc-4.6.0-ebuild-syntax.patch" to 4.6.1, re-digest the ebuild and retry *** Bug 112578 has been marked as a duplicate of this bug. *** Why the new version's ebuild isn't in portage yet? can somebody fix the ebuild here to support the modularized x Created attachment 76542 [details]
mc-4.6.1 ebuild with patches
This aims to be a complete ebuild for mc-4.6.1. I took interesting patches from debian and unicode patches from OpenSUSE. Please test and perhaps consider for merging. Thanks, spity
I've moved the new ebuild in my portage's overlay and it works without any problems on ~x86 with the following use flag: app-misc/mc-4.6.1 USE="X gpm ncurses pam 7zip -nls -samba -slang -unicode" BTW, i've noticed that the 'mc chdir enanchment' script doesn't work anymore, anyone can confirm? overlay from #16 works very well here with all USE flags set, but the ebuild needs to be changed for supporting systems with modularized X, perhaps it can be taken from mc-4.6.0-r14 wher it is included *** Bug 118503 has been marked as a duplicate of this bug. *** Created attachment 76713 [details]
app-misc/mc-4.6.1.ebuild
utf-8 support fixed
Created attachment 76714 [details]
files/mc-4.6.1-utf8.patch.bz2
Created attachment 76715 [details, diff]
files/mc-4.6.1-ebuild-syntax.patch
Created attachment 76716 [details, diff]
files/mc-4.6.1-7zip.patch
*** Bug 119150 has been marked as a duplicate of this bug. *** Created attachment 77334 [details]
app-misc/mc-4.6.1.ebuild
Created attachment 77335 [details]
files/mc-4.6.1-patches.tar.bz2
Created attachment 77336 [details]
files/mc.ini
Created attachment 77337 [details]
files/mcserv.rc
Created attachment 77338 [details]
files/mcserv.pamd
Created attachment 77339 [details]
files/mc-dnlike.color
Created attachment 77340 [details]
files/mc-dark.color
Created attachment 77350 [details]
files/mc-4.6.1-utf8.patch.bz2
I just succeeded (well, almost) with building mc 4.6.1a (the one from mc-4.6.1a-6.src.rpm) and slang 2.0.5 (from slang-2.0.5-5.src.rpm). I used patches from those rpms except for mc-promptfix.patch ( I had to remove from this patch chunk referring to src/subshell.c cause it was breaking stuff as soon as I set LANG to pl_PL.UTF-8 - the prompt was echoed two times). SLANG_HAS_KANJI_SUPPORT was 0 (it seems that while SLsmg_Char_Type was changed to struct those parts of its code were not updated). Anyway mc built this way seems to work correctly in pl_PL.UTF-8 locale (of course I followed that part of mc.spec file about recoding help and hints to utf8) except for one minor issue. Namely, for some reason unicode characters are printed incorrectly on the prompt (actually it's only about characters you enter, neither editor nor viewer nor panels are affected). The bug is: when you enter a character (by keybord or by pasting) the character is entered, but under the cursor appears a dot; you can't delete it cause it's beyond your actual input, if you enter more such characters additional dots appear (all of them group beyond the cursor), if you delete that char, the dot is deleted too. Now I have a problem, those chars don't seem to be form any group that you identify. One group starts at 0x3000, don't know where it ends but 0xf01 is not affected,f6be isn't,0xf929 is, 0xf8ff gets inputed only after you enter at least one more char, some chars after 0xfa00 are affected, but from 0xfb00 aren't. As you may have noticed not all of those chars are kanji. The worst part is I don't know if it's a problem with slang or with mc. I don't know any application supporting utf-8 and slang2 to test it. Why I'm reporting it here instead of Redhat, well... As slang 2 is slowly getting here, and most of us have slang because of mc and utf-8 (at least mutt prefers ncurses to slang - look into the ebuild), this issue should be mentioned here too. A minor correction: the bug actually affects all input fields in mc, so I'm guessing that the problem is somewhere in src/wiget.c in input widget part. (In reply to comment #33) [...] > Namely, for some reason unicode characters are printed incorrectly on the > prompt (actually it's only about characters you enter, neither editor nor > viewer nor panels are affected). The bug is: when you enter a character (by > keybord or by pasting) the character is entered, but under the cursor appears >a dot; you can't delete it cause it's beyond your actual input, if you enter >more such characters additional dots appear (all of them group beyond the >cursor),if you delete that char, the dot is deleted too. I'had the same problem a couple of days ago, that's really strange because i've compiled mc without slang+unicode support. Here the bug doesn't happen every time, it seems to pop out at random times without any apparent reason. I've also tried to use the 'reset' command at the prompt but nothing happened. I think I managed to locate the bug. The problem is caused by double-width chars. If I substitute line c = (res && iswprint (c)) ? 0 : L'.'; with if (res == 0) continue; c = (iswprint (c)) ? 0 : L'.'; problem stops appearing for normal input fields, but persists for password fields. I believe that somebody from Redhat/Fedora team could offer some input about this issue cause it's a problem caused somewhere in their utf-8 patch (for now my bets are charpos/charcolumn and mbstrlen). If anybody reading this is registered at their bugzilla he should repost this there, cause somehow I think they have this issue too. OK, new info. In src/view.c in the old patch there was a block:
+ {
+ int cw = wcwidth(wc);
+ if (cw > 1)
+ col+= cw - 1;
This block is missing in the new patch, but is still needed, cause otherwise double-width chars in viewer aren't displayed at all. Still no idea what is the correct fix for that ./* issue.
Sorry, a typo. There's a closing brace in the next line of the block. Created attachment 77955 [details]
reverting the change
One more thing to add. There's a little change that mc team made in src/mouse.c . They changed escape sequence that enables/disables mouse tracking. Well, while it does work in xterm, it doesn't for in rxvt-unicode. After reverting it, it works fine in both. Sorry, attached diff may have incorrect u header.
Comment on attachment 77955 [details] reverting the change >diff -ur ./mc-4.6.0/src/mouse.c ./mc-4.6.1a/src/mouse.c >--- ./mc-4.6.0/src/mouse.c 2002-09-27 01:13:47.000000000 +0200 >+++ ./mc-4.6.1a/src/mouse.c 2005-09-28 19:21:53.000000000 +0200 >@@ -91,7 +91,7 @@ > printf(ESC_STR "[?1001s"); > > /* enable mouse tracking */ >- printf(ESC_STR "[?1002h"); >+ printf(ESC_STR "[?1000h"); > > fflush (stdout); > mouse_enabled = 1; >@@ -117,7 +117,7 @@ > #endif > case MOUSE_XTERM: > /* disable mouse tracking */ >- printf(ESC_STR "[?1002l"); >+ printf(ESC_STR "[?1000l"); > > /* restore old highlight mouse tracking */ > printf(ESC_STR "[?1001r"); sorry anoter typo, above comments mean they changed it to ?1002h/?1002l and I reverted to ?1000h/?1000l Ok, maybe it's my mistake, mouse handling mode initiated by 1002h is simply not implemented yet in rxvt-unicode, so it's the term that needs patching. However as every thing seems to work correctly it may be a good temporary fix. But that means somebody has to mail it upstream to urxvt developer. *** Bug 121297 has been marked as a duplicate of this bug. *** *** Bug 122055 has been marked as a duplicate of this bug. *** *** Bug 121291 has been marked as a duplicate of this bug. *** *** Bug 124284 has been marked as a duplicate of this bug. *** This should be added to portage ASAP, since it would fix bug #102356 , and make it compile against samba. (That bug is getting alot of duplicates, so it is a bit critical) Before I forget, Redhat patches from above mentioned rpm cause a small bug with double-width chars and password input box. When such char is typed, two stars are shown for each char typed in. I believe that corect way to fix it is to change in widget.c in charcolumn(WInput *in, int idx) line:
pos += l; width += wcwidth(wc);
to:
pos += l; if (wcwidth(wc)>0 && in->is_password) {width++;} else width += wcwidth(wc);
And one more thing: I think in the recent snapshot of mc the mouse issue I mentioned is already solved.
To all the people ingnoring this bug, while thinking that current mc-4.6.1 ebuild solves the problem: IT DOES NOT !!! 1. Snapshots of mc are currently based on slang-2. 2. Problem with the dots/stars I mentioned in some of my comments still persists in this ebuild. 3. There's a patch, mentioned on mc mailing list, adding a partial .deb support without dpkg, which got rejected for not giving as complete support as dpkg, but it would be useful for gentoo, just as rpm2targz script/package is. 4. Redhat has already accepted slang-2 based version, so all new patches from there will be for slang-2, not slang-1. When i start MC i get warnings such as: Warning: file /var/tmp/portage/mc-4.6.1/image//usr/share/mc/extfs/extfs.ini not found Warning: file /var/tmp/portage/mc-4.6.1/image//usr/share/mc/extfs/sfs.ini not found Warning: file /var/tmp/portage/mc-4.6.1/image//usr/share/mc/mc.charsets not found When i try to use help by pressing F1 i get: Cannot open file /var/tmp/portage/mc-4.6.1/image//usr/share/mc/mc.hlp No such file or directory (2) Other functions work incorectly too. MC ver 4.6 works fine, but 4.6.1 no. How i can correct this? In portage, closing. I don't know whether I should open a new bug for this, but I would be simply restating what I wrote here in my comments. Current ebuild does not solve any of issues I stated: dot/star problem persist, ebuild dodges slang-2 move and something I forgot to mention - when mc is built with use unicode and run in an unicode locale hints are cut off at first not-ascii char and help is completely messed up. Redhat solves that issue by converting all .in files for hints and help to utf-8, what is not a bad solution, at least in my opinion. |
